-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Merging Managednetworkfabric/2025-07-15 API from RPSaaSMaster #38669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
idanielsteven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved.
|
I saw lots of breaking changes from last stable because of patch models and sth. else. It that by design when you do the TypeSpec conversion? |
Ans: Yes, this is by design, and communicated to the customers. |
|
@raych1 Could you help to check why this PR is not labeled with swagger breaking change? |
|
@raych1 we had two preview API versions 2024-02-15-preview and 2024-06-15-preview API versions before the current versions 2025-07-15 API. I believe that the reason for Swagger did not report any breaking change |
I added label This is an exceptional case, so our automation might remove label |
mikeharder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking until breaking changes are manually verified. Check Breaking Changes (Cross-Version) cannot detect changes if files are merged and/or renamed.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
"Swagger Breaking Changes" were approved for initial TSP conversion, and "Cross-Version Breaking Changes" in this PR compared the latest stable (TSP) to the latest preview (TSP). So any breaking changes between latest stable and previous stable, should have already been reviewed transitively.
|
"Swagger Breaking Changes" were approved for initial TSP conversion (https://github.com/Azure/azure-rest-api-specs-pr/pull/17974), and "Cross-Version Breaking Changes" in this PR compared the latest stable (TSP) to the latest preview (TSP). So any breaking changes between latest stable and previous stable, should have already been reviewed transitively. |
| model NetworkBootstrapDevicePatch { | ||
| ...TagsUpdate; | ||
|
|
||
| #suppress "@azure-tools/typespec-azure-core/no-legacy-usage" "Legacy flattening" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't suggest adding new flatten properties, could you help to describe why you need to flatten this property here?
pshao25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's work together offline to deal with these breaking changes before proceeding.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.