Prepare specs for C# model naming lint rules - #44762
Draft
haiyuazhang wants to merge 13 commits into
Draft
Conversation
Suppress existing C# SDK naming-rule violations so Azure/typespec-azure#4867 can validate current specs without changing generated API surface. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 869821a6-1f1a-4777-ab20-d49b8490c93e
haiyuazhang
requested review from
a team,
1tariq,
BevLoh,
Draconicida,
Kishp01,
Siongithub,
TimLovellSmith,
a-santamaria,
achyuth-ms,
admayber,
ankushbindlish2,
atastrophic,
danielw5,
efrainretana,
ericshape,
giulianob,
heaths,
hmmorales,
jamestao,
jeremyfrosti,
jocawtho,
naveedaz,
reillyanderson,
seanmcc-msft,
shankarsama,
xiangyan99,
xiong-qiao and
yangylu91
as code owners
July 17, 2026 10:14
haiyuazhang
requested review from
ChenglongLiu,
Ptnan7,
abaccin,
cRui861,
chocomochiko,
denyspanov-public,
dpwatrous,
jruttle,
rrahulms,
skapur12,
vrdmr,
wanghoppe,
wiboris and
wilcobmsft
as code owners
July 17, 2026 10:14
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
Pin typespec-client-generator-core and typespec-azure-rulesets to the immutable Azure/typespec-azure#4867 pkg.pr.new build so TypeSpec validation exercises the new C# naming rules. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 869821a6-1f1a-4777-ab20-d49b8490c93e
TimLovellSmith
left a comment
TimLovellSmith
left a comment
Member
There was a problem hiding this comment.
sign off redis changes
added 3 commits
July 20, 2026 01:48
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0af1189-afe1-444d-9911-3e98e456f3b9
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0af1189-afe1-444d-9911-3e98e456f3b9
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0af1189-afe1-444d-9911-3e98e456f3b9
added 2 commits
July 20, 2026 06:36
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0af1189-afe1-444d-9911-3e98e456f3b9
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0af1189-afe1-444d-9911-3e98e456f3b9
added 6 commits
July 22, 2026 01:55
Pin the latest rule build and update model suffix suppressions to the consolidated diagnostic code. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0af1189-afe1-444d-9911-3e98e456f3b9
Use the compiler build that provides fileRef for the latest typespec-azure preview packages. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0af1189-afe1-444d-9911-3e98e456f3b9
Pin the TypeSpec compiler build that exports fileRef for the latest typespec-azure packages. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0af1189-afe1-444d-9911-3e98e456f3b9
Keep one model suffix suppression where multiple former rule IDs targeted the same declaration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0af1189-afe1-444d-9911-3e98e456f3b9
Bring the companion branch up to date and preserve existing generated C# names for newly added specs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0af1189-afe1-444d-9911-3e98e456f3b9
Use the latest immutable preview for the consolidated C# naming rule. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0af1189-afe1-444d-9911-3e98e456f3b9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares existing TypeSpec specs for Azure/typespec-azure#4867 (
csharp-no-options-suffix,csharp-no-request-suffix,csharp-no-response-suffix, andcsharp-use-standard-acronyms).@azure-tools/typespec-client-generator-coreand@azure-tools/typespec-azure-rulesetsto the immutablepkg.pr.newbuild for Add C# nameing convention linter rules - batch1 typespec-azure#4867 (aec1f704).#suppressdirectives for existing C# SDK model naming violations.Related RPSaaSMaster spec PR: Azure/azure-rest-api-specs-pr#29532
Related typespec-azure PR: Azure/typespec-azure#4867
Validation
git diff --check -- specificationgit diff --check -- package.json package-lock.json