Skip to content

Sync eng/common directory with azure-sdk-tools for PR 16402 - #7233

Merged
helen229 merged 2 commits into
mainfrom
sync-eng-common-feat/rename-azsdk-evals-to-evals-16402
Jul 21, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 16402#7233
helen229 merged 2 commits into
mainfrom
sync-eng-common-feat/rename-azsdk-evals-to-evals-16402

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16402 See eng/common workflow

Copilot AI review requested due to automatic review settings July 21, 2026 17:57
@azure-sdk-automation
azure-sdk-automation Bot requested a review from a team as a code owner July 21, 2026 17:57
@azure-sdk-automation
azure-sdk-automation Bot requested a review from helen229 July 21, 2026 17:57
@azure-sdk-automation azure-sdk-automation Bot added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Jul 21, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
8 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.

Updates the eval suite layout assumptions from azsdk-evals/evals/... to a top-level evals folder with tools/ and workflows/ subtrees, and aligns scripts, tests, and pipelines to the new structure.

Changes:

  • Updated default discovery globs for eval collection and git fixture priming to use tools/ and workflows/ paths.
  • Adjusted unit tests to create and scan fixtures under the new directory layout.
  • Updated pipeline triggers/parameters and relative-link allowlist to reference evals/** instead of azsdk-evals/**.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
eng/common/scripts/eval/test/init-eval-git-fixtures.test.ts Updates fixture directory setup and real-suite invariant scanning to new eval root layout.
eng/common/scripts/eval/test/collect-stimuli.test.ts Updates test fixtures and expected -e args/patterns for new layout.
eng/common/scripts/eval/lib/glob.ts Updates doc example glob to match new default patterns.
eng/common/scripts/eval/init-eval-git-fixtures.ts Changes default patterns for git fixture discovery.
eng/common/scripts/eval/collect-stimuli.ts Changes default patterns for stimuli discovery/matrix build.
eng/common/scripts/allow-relative-links.txt Updates allowlisted path from azsdk-evals/** to evals/**.
eng/common/pipelines/workflow-eval.yml Updates trigger paths and vallyRoot to point at evals.
eng/common/pipelines/templates/stages/archetype-eval.yml Updates default evalGlobs to new layout.
eng/common/pipelines/live-eval.yml Updates vallyRoot and live eval glob path.

Comment thread eng/common/scripts/eval/test/init-eval-git-fixtures.test.ts
Comment thread eng/common/scripts/eval/test/init-eval-git-fixtures.test.ts
Comment thread eng/common/scripts/eval/test/collect-stimuli.test.ts
@helen229
helen229 merged commit 0ba1144 into main Jul 21, 2026
90 checks passed
@helen229
helen229 deleted the sync-eng-common-feat/rename-azsdk-evals-to-evals-16402 branch July 21, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants