Sync eng/common directory with azure-sdk-tools for PR 16402 - #7233
Merged
helen229 merged 2 commits intoJul 21, 2026
Conversation
|
Azure Pipelines: Successfully started running 2 pipeline(s). 8 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the eval suite layout assumptions from azsdk-evals/evals/... to a top-level evals folder with tools/ and workflows/ subtrees, and aligns scripts, tests, and pipelines to the new structure.
Changes:
- Updated default discovery globs for eval collection and git fixture priming to use
tools/andworkflows/paths. - Adjusted unit tests to create and scan fixtures under the new directory layout.
- Updated pipeline triggers/parameters and relative-link allowlist to reference
evals/**instead ofazsdk-evals/**.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/common/scripts/eval/test/init-eval-git-fixtures.test.ts | Updates fixture directory setup and real-suite invariant scanning to new eval root layout. |
| eng/common/scripts/eval/test/collect-stimuli.test.ts | Updates test fixtures and expected -e args/patterns for new layout. |
| eng/common/scripts/eval/lib/glob.ts | Updates doc example glob to match new default patterns. |
| eng/common/scripts/eval/init-eval-git-fixtures.ts | Changes default patterns for git fixture discovery. |
| eng/common/scripts/eval/collect-stimuli.ts | Changes default patterns for stimuli discovery/matrix build. |
| eng/common/scripts/allow-relative-links.txt | Updates allowlisted path from azsdk-evals/** to evals/**. |
| eng/common/pipelines/workflow-eval.yml | Updates trigger paths and vallyRoot to point at evals. |
| eng/common/pipelines/templates/stages/archetype-eval.yml | Updates default evalGlobs to new layout. |
| eng/common/pipelines/live-eval.yml | Updates vallyRoot and live eval glob path. |
helen229
approved these changes
Jul 21, 2026
helen229
deleted the
sync-eng-common-feat/rename-azsdk-evals-to-evals-16402
branch
July 21, 2026 20:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16402 See eng/common workflow