Sync eng/common directory with azure-sdk-tools for PR 16402 - #49878
Merged
helen229 merged 2 commits intoJul 21, 2026
Conversation
azure-sdk-automation
Bot
added
EngSys
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the eval suite layout assumptions across scripts, tests, and pipelines to use a top-level evals/ directory containing tools/ and workflows/ instead of azsdk-evals/evals/....
Changes:
- Updated default eval glob patterns to
tools/*.eval.yamlandworkflows/mock/*.eval.yaml. - Refactored test fixtures to create/read eval files under
tools/andworkflows/. - Adjusted pipeline triggers/parameters and relative-link allowlist to reference
evals/**.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/common/scripts/eval/test/init-eval-git-fixtures.test.ts | Updates fixture paths and real-fixture scanning roots to the new evals/tools + evals/workflows layout. |
| eng/common/scripts/eval/test/collect-stimuli.test.ts | Updates test eval file locations and expected -e arguments to align with tools/ and workflows/. |
| eng/common/scripts/eval/lib/glob.ts | Updates JSDoc example glob to match the new directory layout. |
| eng/common/scripts/eval/init-eval-git-fixtures.ts | Updates default fixture-discovery patterns to the new layout. |
| eng/common/scripts/eval/collect-stimuli.ts | Updates default stimuli-discovery patterns to the new layout. |
| eng/common/scripts/allow-relative-links.txt | Updates allowlisted eval suite root from azsdk-evals/** to evals/**. |
| eng/common/pipelines/workflow-eval.yml | Updates path triggers and vallyRoot to use evals. |
| eng/common/pipelines/templates/stages/archetype-eval.yml | Updates default evalGlobs patterns to match tools/ and workflows/. |
| eng/common/pipelines/live-eval.yml | Updates vallyRoot and live eval globs to use evals/workflows/live. |
helen229
approved these changes
Jul 21, 2026
helen229
deleted the
sync-eng-common-feat/rename-azsdk-evals-to-evals-16402
branch
July 21, 2026 18:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16402 See eng/common workflow