Sync eng/common directory with azure-sdk-tools for PR 16402 - #10161
Merged
Praveen Kuttappan (praveenkuttappan) merged 2 commits intoJul 21, 2026
Merged
Conversation
azure-sdk-automation
Bot
added
EngSys
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
This PR updates the eval suite layout assumptions across scripts, tests, and pipelines to use top-level evals/ with tools/ and workflows/ subfolders (instead of azsdk-evals/evals/...).
Changes:
- Updated default glob patterns and tests to discover eval files under
tools/andworkflows/. - Adjusted fixture discovery tests/invariants to scan
evals/tools+evals/workflowsunder the repo root. - Updated pipeline triggers and parameters to point at
evals/**and new workflow/live glob locations.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| eng/common/scripts/eval/test/init-eval-git-fixtures.test.ts | Updates test fixture tree + real-fixture invariant scanning to new eval folder layout. |
| eng/common/scripts/eval/test/collect-stimuli.test.ts | Updates test data and assertions to reflect new patterns and relative paths. |
| eng/common/scripts/eval/lib/glob.ts | Updates glob documentation example to match new patterns. |
| eng/common/scripts/eval/init-eval-git-fixtures.ts | Updates default patterns for fixture discovery to new folder names. |
| eng/common/scripts/eval/collect-stimuli.ts | Updates default patterns for stimuli discovery to new folder names. |
| eng/common/scripts/allow-relative-links.txt | Allows relative links under evals/** instead of azsdk-evals/**. |
| eng/common/pipelines/workflow-eval.yml | Updates triggers and vallyRoot to evals. |
| eng/common/pipelines/templates/stages/archetype-eval.yml | Updates default evalGlobs to match new layout. |
| eng/common/pipelines/live-eval.yml | Updates vallyRoot and live eval globs to workflows/live/*.eval.yaml. |
Helen Gao (helen229)
approved these changes
Jul 21, 2026
Praveen Kuttappan (praveenkuttappan)
merged commit Jul 21, 2026
c4cda69
into
main
8 of 9 checks passed
Praveen Kuttappan (praveenkuttappan)
deleted the
sync-eng-common-feat/rename-azsdk-evals-to-evals-16402
branch
July 21, 2026 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16402 See eng/common workflow