Cleanup in preparation for sync refactor #3217
Conversation
gapra-msft
requested review from
adreed-msft,
dphulkar-msft,
seanmcc-msft,
souravgupta-msft,
tanyasethi-msft,
vibhansa-msft and
wonwuakpa-msft
as code owners
| return srcServiceClient, srcCredType, nil | ||
| } | ||
|
|
||
| func GetDestinationServiceClient(ctx context.Context, |
There was a problem hiding this comment.
ditto
- Can this be consolidated into one function to reduce code dupe?
There was a problem hiding this comment.
Creating an item for this. There are some updates I need to make with the method args so I'll clean it up at once after the core of the migration is done
| @@ -0,0 +1,144 @@ | |||
| package azcopy | |||
There was a problem hiding this comment.
Don't we need the microsoft licensing header?
| srcReauthTok = (*common.ScopedAuthenticator)(common.NewScopedCredential(at, common.ECredentialType.OAuthToken())) | ||
| } | ||
|
|
||
| options := traverser.CreateClientOptions(common.AzcopyCurrentJobLogger, nil, srcReauthTok) |
There was a problem hiding this comment.
Should we add a condition in the client creation for if we're not using OAuth tokens?
| @@ -0,0 +1,122 @@ | |||
| package cmd | |||
|
|
|||
There was a problem hiding this comment.
missing licensing header
| @@ -0,0 +1,122 @@ | |||
| package cmd | |||
There was a problem hiding this comment.
missing Microsoft licensing header
|
|
||
| // Create Destination Client. | ||
| var azureFileSpecificOptions any | ||
| if fromTo.To() == common.ELocation.File() || fromTo.To() == common.ELocation.FileNFS() { |
There was a problem hiding this comment.
fromTo.To().IsFile()
| if fromTo.To() == common.ELocation.File() || fromTo.To() == common.ELocation.FileNFS() { | |
| if fromTo.To() == common.ELocation.File() || fromTo.To() == common.ELocation.FileNFS() { |
|
|
||
| // Create Source Client. | ||
| var azureFileSpecificOptions any | ||
| if loc == common.ELocation.File() || loc == common.ELocation.FileNFS() { |
There was a problem hiding this comment.
loc.IsFile()
| if loc == common.ELocation.File() || loc == common.ELocation.FileNFS() { | |
| if loc == common.ELocation.File() || loc == common.ELocation.FileNFS() { |
| preserveOwner bool | ||
| preserveSMBInfo bool | ||
| preservePOSIXProperties bool | ||
| followSymlinks bool |
There was a problem hiding this comment.
Why did we remove it? we will need this for NFS
| cooked.destination = common.ResourceString{Value: common.ToExtendedPath(common.CleanLocalPath(raw.dst))} | ||
| } | ||
|
|
||
| if err = cooked.symlinkHandling.Determine(raw.followSymlinks, raw.preserveSymlinks); err != nil { |
|
Left few comments. |
Description
Feature / Bug Fix: (Brief description of the feature or issue being addressed)
Related Links:
Issues
Team thread
Documents
[Email Subject]
Type of Change
How Has This Been Tested?
Thank you for your contribution to AzCopy!