-
Notifications
You must be signed in to change notification settings - Fork 500
Add Dark Mode support for Windows #6666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
790880a to
d0a5c6f
Compare
|
Nice PR number for such a change, btw |
For Windows use |
|
|
Yes, it looks like this is really better. Good catch! |
| // wxWidgets' IsDark() returns false on Win 11 now even if dark mode is enabled | ||
| // so we need to additionally check the registry for the dark mode setting | ||
| m_isDarkMode = m_isDarkMode || IsWindowsInDarkMode(); | ||
| MSWEnableDarkMode(wxApp::DarkMode_Auto); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is needed? I do remember when I tested the dark mode, I didn't have this enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did it according to docs. Yes, without it just ignores OS settings
|
@AufarZakiev @AenBleidd Please make absolutely sure that all your changes are guarded by |
or |
|
@CharlieFenton, of course we will, no worries. This is too far from being finished, and it's too early to talk about this now, but this is definitely something I will keep in mind while doing a review of the code. |
d0a5c6f to
6f72d16
Compare
6f72d16 to
83f4cf0
Compare
Fixes #5274
Description of the Change
Note: wxWidgets' IsDark() returns
falseon Win 11 now even if dark mode is enabled. Therefore, registry reading mechanism was introduced as an additional checkTested on Win 11.
Alternate Designs
Screenshots:
Release Notes
Add Dark Mode support for Windows