Fix NPE for filter with and predicate in path step#2687
Merged
Conversation
Member
|
…merci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported by Andreas Hengsbach on basex-talk, an NPE can result from
andexpression, involvingE.g.
This can also be reproduced as simple as
It is caused by
Path.getrewriting a filter expression to a self step with predicates. In the course of this, the predicates are queried forFlag.POS(viamayBePositional()). But when this is done at parse time,FuncRefs are not resolved yet - yielding an NPE for the flags request.However it is not necessary to do the rewrite this early, an equivalent rewrite is also done at optimization time, in
Filter.optimize. So the fix is to just remove it fromPath.get.