Remove agent.py from handler and add docs on how to implement Agents
#464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
will need to be cherry-picked on top of #424, changing to draft until that lands. |
jfeser
requested changes
Dec 27, 2025
Contributor
jfeser
left a comment
jfeser
left a comment
There was a problem hiding this comment.
That notebook is getting unwieldy, so let's add this to the documentation as a code example like the beam search.
jfeser
reviewed
Dec 27, 2025
kiranandcode
force-pushed
the
kg-remove-agent
branch
from
c246055 to
c64e4cd
Compare
jfeser
previously requested changes
Jan 2, 2026
Contributor
|
The original |
Contributor
Author
|
@eb8680 ah, good point, removed! |
eb8680
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
agent.pyand updatesllm.ipynbto describe how to implement Agents. Method templates were broken so it relies on #463 and should be merged after that lands. Closes #461The agent class in
agent.pyalso needed some modification to make it work with the latest functionality. It was actually somewhat broken.