fix: handle non-ASCII characters in page paths for Tailwind compilation#855
Open
pshoukry wants to merge 1 commit intoBeaconCMS:mainfrom
Open
fix: handle non-ASCII characters in page paths for Tailwind compilation#855pshoukry wants to merge 1 commit intoBeaconCMS:mainfrom
pshoukry wants to merge 1 commit intoBeaconCMS:mainfrom
Conversation
The `remove_special_chars/1` function uses `[^[:alnum:]_]` regex which allows Unicode letters (Arabic, Chinese, etc.) through. The Tailwind CLI binary cannot handle UTF-8 filenames, causing ENOENT errors during boot. This fix hashes non-ASCII paths using `:erlang.phash2/1` to create safe ASCII-only filenames, while preserving the existing behavior for ASCII paths. Fixes boot crash when pages have non-Latin paths like `/مدونة` or `/博客`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
remove_special_chars/1function inTailwindCompileruses[^[:alnum:]_]regex which allows Unicode letters (Arabic, Chinese, etc.) through. The Tailwind CLI binary cannot handle UTF-8 filenames, causing ENOENT errors during boot when pages have non-Latin paths.Error example:
Solution
Hash non-ASCII paths using
:erlang.phash2/1to create safe ASCII-only filenames, while preserving the existing behavior for ASCII-only paths.Before:
After:
Testing
/مدونة)