Fix embedded factory override handling for non-hash values#68
Merged
BillyRuffian merged 2 commits intoJul 22, 2026
Merged
Conversation
added 2 commits
July 14, 2026 13:17
…spec tests for omit, nil, and hash override behaviour
BillyRuffian
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix type error when overriding an embedded factory attribute with a non-hash value
value_for_attributechecked!attr.embedded_factories?before checking for an override. This meant non-hash overrides (e.g.FakerMaker::OMIT, nil) for embedded factory attributes weren't taken into account. The method fell through to building the embedded factory which then failed with aundefined methoderror .Fix: Check
overridden_value?first, then only delegate to the embedded factory build when the override is a Hash. Non-hash overrides are now returned directly, allowingFakerMaker::OMITandnilto work as expected for embedded attributes.