feat(wrw): add PSBT-based recovery with signing workflow and test infrastructure#706
Merged
Conversation
Replace the form's optional recipientAmount field with a required recipientAddress + feeRateSatVB. The backend (buildOutput) reads input values from the PSBT via BitGoPsbt.getInputs(), estimates transaction vsize using Dimensions.fromPsbt + Dimensions.fromOutput, computes fee = feeRateSatVB * vsize, and adds a single output for the remainder. PSBT must have zero outputs on entry — validated before signing. T1-3271
- Add vitest setup with jsdom, @testing-library/react cleanup - Add tsconfig.test.json (composite) for type-checking tests and eslint project service; use explicit project array in eslint.config.mjs - Add App.test.tsx: smoke tests for render, bigint-buffer binding errors - Add SignPsbt.test.tsx: unit tests for form fields and container routing - Add e2e/sign-psbt.spec.ts: web-server tests covering form rendering, coin selector, passphrase conditional, cancel navigation - Add e2e/utxo/sign-psbt.spec.ts: Electron test that signs a real tbtc p2wsh PSBT (inputs-only fixture) and verifies success page - Add e2e/utxo/helpers.ts: shared launchApp() — Electron launch, 1440x900 window resize, waitForSelector - Update e2e/utxo/blockchain-recovery.spec.ts to use launchApp() - playwright.config.ts: enable screenshot on every run - eslint.config.mjs: ignore playwright-report/ and test-results/ - Install electron@22.3.25 (required for ELECTRON_RUN_AS_NODE fix) T1-3273
davidkaplanbitgo
approved these changes
May 8, 2026
| @@ -0,0 +1,139 @@ | |||
| import { test, expect } from '@playwright/test'; | |||
|
|
|||
| test.describe('Sign PSBT E2E Tests', () => { | |||
| 'dash', 'tdash', 'zec', 'tzec', 'bch', 'tbch', 'btg', 'tbtg', | ||
| ] as const; | ||
|
|
||
| export type UtxoCoin = (typeof UTXO_COINS)[number]; |
Contributor
Author
There was a problem hiding this comment.
I will do so in a follow-up
|
@claude please review. be first principles and reason all changes |
ppongbitgo
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements PSBT-based UTXO recovery for the WRW with complete signing workflow, fee calculation, and
comprehensive test coverage.
Changes
T1-3271
T1-3272
T1-3273