Skip to content

Alert Missions - #585

Draft
fcelar wants to merge 3 commits into
BlackyHawky:mainfrom
fcelar:missions
Draft

Alert Missions#585
fcelar wants to merge 3 commits into
BlackyHawky:mainfrom
fcelar:missions

Conversation

@fcelar

@fcelar fcelar commented May 16, 2026

Copy link
Copy Markdown

Summary

This PR adds configurable alarm missions that require user interaction before an alarm can be dismissed. It introduces mission persistence, integrates missions into the alarm flow, and adds UI/settings for configuring mission behavior, including QR scanning support.

Changes

  • Add alarm mission domain models and persistence:
    • AlarmMission
    • MathAlarmMission
    • QrAlarmMission
    • NoAlarmMission
  • Update database/provider layers to store and expose mission data
  • Wire missions into the active alarm flow and dismissal logic
  • Add math and QR mission controllers
  • Add mission configuration to alarm settings and alarm edit UI
  • Add QR capture activity, resources, and manifest/config updates
  • Update backup/restore handling for mission-related data

Commits

  • 69edc2224 Add alarm mission model and persistence
  • 420e4bb55 Wire missions into alarm flow
  • ba1625dbc Add mission settings and QR scanning

Notes

Users can now configure alarms with:

  • no mission
  • math mission
  • QR mission

@fcelar fcelar mentioned this pull request May 18, 2026
@BlackyHawky

Copy link
Copy Markdown
Owner

Hi,

This is a huge pull request...

It would have been better to discuss this beforehand, especially since I had planned a lot of changes, which is why there are conflicts now.

Also:

  • You're adding two separate features: dismissing the alarm using tasks and dismissing the alarm using a QR code.
    As stated in the contribution guide: "Keep PRs focused on a single topic.";

  • After a very quick glance, particularly regarding dismissing the alarm via QR code, you’re implementing the "zxing-android-embedded" library, which hasn’t been updated in a very long time... Furthermore, there appears to be a licensing conflict, as noted in this issue.
    Wouldn’t it have been better to use "quickie" which seems more up-to-date?

Personally, I think it’s totally useless to turn off an alarm with a QR code or something like that.

Since when do people need that to wake up in the morning?

It feels like big corporations have created completely unnecessary needs...

Honestly, if you have to wake up in the morning to make a living, you don’t need that kind of gimmick... Trust me.

@BlackyHawky
BlackyHawky marked this pull request as draft May 29, 2026 16:00
@fcelar

fcelar commented Jun 1, 2026

Copy link
Copy Markdown
Author

Hey, I'll update the PR once I get a free moment. I'll try to simplify it. About the QR code dismiss feature: it’s definitely a convenience thing. Some heavy sleepers really need that option to avoid oversleeping, so it's a great quality-of-life addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants