Skip to content

Datadog integration - #125

Merged
maxhov merged 37 commits into
Blazebit:mainfrom
mjsprengers:datadog_integration
Mar 25, 2026
Merged

maxhov merged 37 commits into
Blazebit:mainfrom
mjsprengers:datadog_integration

Conversation

@mjsprengers

Copy link
Copy Markdown
Contributor

No description provided.

mjsprengers and others added 30 commits October 30, 2024 09:21
@maxhov

maxhov commented Mar 25, 2026 •

Copy link
Copy Markdown
Collaborator

Code review

Found 3 issues:

  1. Azure DevOps imports and registerSchemaObjectAlias calls removed from Main.java without explanation. Three imports (WorkItem, GitRepository, PolicyConfiguration) and their corresponding alias registrations are deleted, but the azure-devops dependency remains in build.gradle. This appears to be an accidental deletion unrelated to the Datadog connector.

queryContextBuilder.setProperty( EntityViewConnectorConfig.ENTITY_VIEW_MANAGER.getPropertyName(), evm );
// queryContextBuilder.setProperty( ObservatoryConnectorConfig.OBSERVATORY_CLIENT.getPropertyName(), createObservatoryClient());
queryContextBuilder.setProperty( DatadogConnectorConfig.DATADOG_API_CLIENT.getPropertyName(), createDatadogApiClient());
// queryContextBuilder.setProperty( GitlabConnectorConfig.GITLAB_API.getPropertyName(), createGitlabApi());
// queryContextBuilder.setProperty( GitlabGraphQlConnectorConfig.GITLAB_GRAPHQL_CLIENT.getPropertyName(), createGitlabGraphQLClient());

  1. Datadog configuration and testDatadog() call left uncommented in Main.java, while all other providers are commented out. The empty credential constants (DATADOG_API_KEY = "", DATADOG_APP_KEY = "") combined with an active testDatadog(session) call will cause a runtime failure for anyone running the example app without Datadog credentials.

private static final String DATADOG_API_KEY = "";
private static final String DATADOG_APP_KEY = "";
private static final String DATADOG_SITE = "datadoghq.eu";

// testGcp( session );
// testGoogleWorkspace( session );
testDatadog( session );
// testAws( session );

  1. Duplicate testGcp() and testGoogleWorkspace() calls in Main.java -- both active and commented-out versions exist adjacent to each other, causing those tests to execute twice.

// testJiraCloudAdmin( session );
testGcp( session );
testGoogleWorkspace( session );
testGoogleEndpointVerification( session );
// testGcp( session );
// testGoogleWorkspace( session );
testDatadog( session );

@maxhov
maxhov merged commit e0ea178 into Blazebit:main Mar 25, 2026
2 checks passed
mjsprengers added a commit to mjsprengers/blaze-query that referenced this pull request Apr 1, 2026
Conflicts resolved by keeping our removal of the isForbidden 403 suppression,
which was introduced in main via the Datadog integration PR (Blazebit#125).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants