Add user agent when default_user_agent_disabled is false#123
Merged
Conversation
diego-ferrand
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances how the HTTP/2 plugin sets the
User-Agentheader by introducing logic to add a defaultUser-Agentwhen none is configured, unless explicitly disabled via a property. It also adds comprehensive tests to verify this behavior, ensuring compatibility with legacy behavior and configurability.User-Agent header handling improvements:
JmeterRequestHeadersSupportto automatically set a defaultUser-Agentheader ("BlazeMeter HTTP"or"BlazeMeter HTTP/<version>") if none is provided, unless thehttpclient4.default_user_agent_disabledproperty is set totrue. This matches the legacy behavior ofHTTPHC4Impland improves interoperability. [1] [2]JmeterRequestHeadersSupportto support the new defaultUser-Agentlogic, including property checks and default value construction. [1] [2]Testing enhancements:
JmeterRequestHeadersSupportTestto verify that the defaultUser-Agentis set when missing, not overridden if already present (including empty values), and omitted when the disabling property is set.Dependency and import updates:
JMeterUtils,StringUtils, and test utilities to support the new logic and tests. [1] [2]