Fix tests so they work with all multi-monitor setups #457
+4
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setup of having a monitor to the left or above the primary monitor was not working correctly. A number of tests would fail.
Contributor
|
Sorry about that! I recently added that runtime check, not realizing that Windows would assign monitors to the left of the primary monitor negative coordinates. Thanks for catching it! |
Owner
|
Thank you @halldorfannar, that would have been an bad regression if I had cut a release with the code you fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setup of having a monitor to the left or above the primary monitor was not working correctly. A number of tests would fail.
Changes proposed in this PR
This fixes 25 test failures I would otherwise get on my multi-monitor Windows machine. These changes are internally facing and therefore do not warrant a CHANGELOG.md entry or documentation update.
./check.shpassed