Feat : New command and button to teleport to a random warp#101
Open
Redstoner507 wants to merge 1 commit into
Open
Feat : New command and button to teleport to a random warp#101Redstoner507 wants to merge 1 commit into
Redstoner507 wants to merge 1 commit into
Conversation
Zoriot
requested changes
Jul 18, 2026
| return handleMigrateCommand(player, args); | ||
| } | ||
|
|
||
| if (args[0].equalsIgnoreCase("random")) { |
Collaborator
There was a problem hiding this comment.
This subcommand currently bypasses the warp use permission.
| return handleMigrateCommand(player, args); | ||
| } | ||
|
|
||
| if (args[0].equalsIgnoreCase("random")) { |
Collaborator
There was a problem hiding this comment.
The random subcommand doesn't show up in auto completion + all the other commands also not. Would probably make sense to fix that here
| package net.buildtheearth.buildteamtools.modules.navigation.components.warps.commands; | ||
|
|
||
| import com.alpsbte.alpslib.utils.ChatHelper; | ||
| import jdk.jshell.execution.Util; |
Collaborator
There was a problem hiding this comment.
Please remove the unused imports
| @@ -1,5 +1,6 @@ | |||
| package net.buildtheearth.buildteamtools.modules.navigation.components.warps.menu; | |||
|
|
|||
| import jdk.jshell.execution.Util; | |||
Collaborator
There was a problem hiding this comment.
Please remove the unused import
|
|
||
| public static final int BACK_ITEM_SLOT = 27; | ||
| public static final int SWITCH_PAGE_ITEM_SLOT = 34; | ||
| public static final int RANDOM_ITEM_SLOT = 33; |
Collaborator
There was a problem hiding this comment.
This overlaps with the buttons for the pages
Collaborator
There was a problem hiding this comment.
What do you think of introducing a subpermission for random warps? and if the user doesn't have the permission the button + subcommand are not shown / executable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented random warp teleportation (Issue #80)