improving skeleton service by upgrading python, messaging client, and tests - #13
Open
fcollman wants to merge 11 commits into
Open
improving skeleton service by upgrading python, messaging client, and tests#13fcollman wants to merge 11 commits into
fcollman wants to merge 11 commits into
Conversation
skeletonservice/datasets/messaging.py imports RetryableError, which first appears in messagingclient 0.6.0. requirements.in previously had messagingclient unconstrained and the lock pinned 0.3.0, so a build would have installed a version without it and failed at import. Verified against the published 0.6.0 (not a local checkout): it exports RetryableError, and its consume loop nacks via modify_ack_deadline and continues rather than stopping. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this upgrades python to python 3.11 in order to include messagingclient 0.6.0 which will enable retryableexception to no-ack messages and trigger retries. It also fixes many broken tests that were due to tests assuming the previous patches were applied which makes the test suite order dependant and therefore not reproducible.