Server-side config for GCS token expiration - #9
Merged
fcollman merged 2 commits intoMar 18, 2026
Conversation
- Add SKELETON_TOKEN_EXPIRATION_MINUTES=60 to BaseConfig in config.py - Re-add expiration_minutes param to get_skeleton_token_by_datastack_and_rids() sourced from server config (not client request body) - Cap reported token expiry to min(credential_expiry, now + expiration_minutes) with proper timezone-aware datetime comparison - api.py reads SKELETON_TOKEN_EXPIRATION_MINUTES from Flask app config and passes it down to the service layer Co-authored-by: fcollman <782341+fcollman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update skeleton service for enhanced performance
Server-side config for GCS token expiration
Mar 14, 2026
fcollman
marked this pull request as ready for review
March 18, 2026 09:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expiration_minuteswas removed from the token endpoint in PR #8, but the reviewer wants expiry controlled server-side via config rather than omitted entirely.Changes
config.py: AddedSKELETON_TOKEN_EXPIRATION_MINUTES = 60toBaseConfig; overridable viaconfig.cfgor env-based configservice.py: Re-addedexpiration_minutes: int = 60param toget_skeleton_token_by_datastack_and_rids(); caps reportedexpirytomin(credential_expiry, now + expiration_minutes)with timezone-aware comparison (google-auth returns naive UTC datetimes)api.py:post()readsSKELETON_TOKEN_EXPIRATION_MINUTESfrom Flask app config and threads it throughprocess()→ service; no client-supplied expiryOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.