-
Notifications
You must be signed in to change notification settings - Fork 513
[IMPROVEMENT]: Ensure WebVTT output includes minimal X-TIMESTAMP-MAP for HLS compatibility #1744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[IMPROVEMENT]: Ensure WebVTT output includes minimal X-TIMESTAMP-MAP for HLS compatibility #1744
Conversation
d19433c to
acc40f3
Compare
…WebVTT for HLS compatibility
acc40f3 to
911b2b8
Compare
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 3f44115...:
All tests passing on the master branch were passed completely. Check the result page for more info. |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 3f44115...:
Congratulations: Merging this PR would fix the following tests:
All tests passing on the master branch were passed completely. Check the result page for more info. |
cfsmp3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has merge conflicts and needs to be rebased against the current master branch.
Please resolve the conflicts and update the PR. The feature itself looks useful for HLS compatibility.
|
Thank you for working on this HLS compatibility feature! I tested it and found: Works: Default output filename correctly includes Bug: When using Rebase needed: This PR is 4+ months old and contains unrelated To fix the
|
|
Hi @AbHash-RixE, this PR is over 4 months old and has some issues:
Are you still interested in completing this? If not, we may close it and implement the feature differently. |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
SUMMARY
This PR ensures that when
--timestamp-map&--out=webvttis used and no captions are detected, CCExtractor still writes a minimal header containing :X-TIMESTAMP-MAP=MPEGTS:0,LOCAL:00:00:00.000This makes the generated .vtt file valid for HLS players, which often require this header even in empty subtitle files.
IMPLEMENTATION DETAILS
CHANGES.TXT-Added entry under Unreleased: 1.0
IMPROVEMENT: Add default X-TIMESTAMP-MAP header for empty subtitle files in WebVTT for better compatibility
of HLS streaming (#1743)
src/ccextractor.c-Call
webvtt_write_minimal_header()instart_ccx()when no captions are found and--out=webvttis set.src/lib_ccx/ccx_encoders_helpers.c-Added new helper function
webvtt_write_minimal_header()-Which:
Initializes encoder context for WebVTT.
Writes a default
X-TIMESTAMP-MAP=MPEGTS:0,LOCAL:00:00:00.000line.Ensures line terminator respects user config (LF vs CRLF).
Cleans up encoder context properly.
src/lib_ccx/ccx_encoders_helpers.h-Declared the new function:
void webvtt_write_minimal_header(void);