Skip to content

chore: Remove progress bar feature#879

Merged
RobertJacobsonCDC merged 1 commit into
mainfrom
RobertJacobsonCDC_834_remove_progress_bar
May 8, 2026
Merged

chore: Remove progress bar feature#879
RobertJacobsonCDC merged 1 commit into
mainfrom
RobertJacobsonCDC_834_remove_progress_bar

Conversation

@RobertJacobsonCDC
Copy link
Copy Markdown
Collaborator

Removed the progress bar feature. This deletes the progress API/module, removes the timeline progress update from Context, drops the --timeline-progress-max runner option, and simplifies logging by removing the progress-bar-specific encoder wrapper.

The feature/dependency wiring and runner integration test were removed, and the CLI docs were regenerated so the removed flag no longer appears. The performance docs no longer describe progress bar APIs.

@RobertJacobsonCDC RobertJacobsonCDC linked an issue May 5, 2026 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Benchmark Results

Hyperfine

Command Mean [ms] Min [ms] Max [ms] Relative
large_sir::baseline 2.9 ± 0.2 2.7 3.9 1.00
large_sir::entities 6.3 ± 0.3 6.1 7.7 2.17 ± 0.16

Criterion

Regressions (slower)
Group Bench Param Change CI Lower CI Upper
examples example-basic-infection 14.306% 13.397% 15.217%
indexing with_query_results_multiple_individually_indexed_properties_enti 12.199% 11.360% 13.438%
indexing query_people_single_indexed_property_entities 9.021% 7.971% 10.164%
algorithm_benches algorithm_sampling_single_known_length 5.704% 4.685% 6.504%
sample_entity sample_entity_multi_property_indexed 1000 3.936% 3.193% 5.008%
large_dataset bench_query_population_multi_indexed_entities 3.424% 2.839% 4.165%
indexing query_people_indexed_multi-property_entities 2.373% 1.331% 3.515%
sample_entity sample_entity_whole_population 10000 1.951% 1.415% 2.670%
sample_entity sample_entity_multi_property_indexed 100000 1.666% 1.190% 2.129%
counts multi_property_indexed_entities 1.579% 1.212% 1.850%
sampling count_and_sampling_single_unindexed_concrete_plus_derived_entiti 1.458% 1.234% 1.685%
indexing query_people_count_multiple_individually_indexed_properties_enti 1.379% 1.125% 1.613%
Improvements (faster)
Group Bench Param Change CI Lower CI Upper
counts single_property_indexed_entities -24.284% -26.526% -22.051%
large_dataset bench_query_population_derived_property_entities -15.281% -15.615% -14.934%
large_dataset bench_match_entity -12.971% -15.054% -10.897%
sample_entity sample_entity_single_property_unindexed 1000 -12.415% -14.874% -9.869%
large_dataset bench_filter_unindexed_entity -9.202% -13.659% -4.732%
large_dataset bench_query_population_indexed_property_entities -5.785% -8.607% -2.217%
sampling sampling_single_known_length_entities -3.715% -5.895% -1.954%
sampling count_and_sampling_single_known_length_entities -3.523% -4.271% -2.737%
sample_entity sample_entity_whole_population 1000 -2.979% -3.742% -2.462%
sampling sampling_multiple_l_reservoir_entities -2.553% -3.063% -2.081%
sampling sampling_single_l_reservoir_entities -2.036% -2.820% -1.286%
sampling sampling_multiple_known_length_entities -2.027% -2.883% -1.102%
indexing with_query_results_single_indexed_property_entities -1.934% -2.495% -1.331%
sample_entity sample_entity_single_property_indexed 10000 -1.747% -2.282% -1.354%
algorithm_benches algorithm_sampling_multiple_l_reservoir -1.734% -2.171% -1.330%
Unchanged / inconclusive (CI crosses 0%)
Group Bench Param Change CI Lower CI Upper
large_dataset bench_filter_indexed_entity -5.374% -14.903% 6.449%
sample_entity sample_entity_multi_property_indexed 10000 1.628% 0.985% 2.228%
sample_entity sample_entity_single_property_indexed 100000 -1.346% -1.831% -0.858%
sample_entity sample_entity_single_property_unindexed 10000 -1.345% -3.958% 1.519%
indexing query_people_count_indexed_multi-property_entities -1.296% -1.711% -0.901%
sample_entity sample_entity_whole_population 100000 1.227% 0.929% 1.629%
sample_entity sample_entity_single_property_indexed 1000 -1.162% -1.648% -0.835%
examples example-births-deaths 1.089% 0.811% 1.316%
sampling sampling_single_unindexed_concrete_plus_derived_entities -1.054% -1.468% -0.630%
indexing query_people_count_single_indexed_property_entities -1.019% -1.412% -0.731%
counts concrete_plus_derived_unindexed_entities -1.000% -1.427% -0.539%
counts multi_property_unindexed_entities 0.999% 0.776% 1.218%
indexing with_query_results_indexed_multi-property_entities 0.922% 0.749% 1.079%
counts index_after_adding_entities 0.873% 0.692% 1.089%
counts reindex_after_adding_more_entities 0.851% 0.581% 1.089%
algorithm_benches algorithm_sampling_multiple_known_length -0.797% -1.137% -0.547%
sampling sampling_single_unindexed_entities -0.712% -0.827% -0.575%
sampling sampling_multiple_unindexed_entities -0.438% -0.673% -0.194%
sample_entity sample_entity_single_property_unindexed 100000 -0.410% -0.674% -0.176%
indexing query_people_multiple_individually_indexed_properties_entities -0.198% -0.540% 0.179%
algorithm_benches algorithm_sampling_single_l_reservoir -0.174% -0.430% 0.119%
algorithm_benches algorithm_sampling_single_rand_reservoir -0.146% -0.444% 0.074%
large_dataset bench_query_population_property_entities -0.121% -0.526% 0.161%
counts single_property_unindexed_entities -0.083% -0.368% 0.231%
large_dataset bench_query_population_multi_unindexed_entities 0.078% -0.351% 0.380%

github-actions Bot added a commit that referenced this pull request May 5, 2026
@RobertJacobsonCDC RobertJacobsonCDC force-pushed the RobertJacobsonCDC_834_remove_progress_bar branch from 07f51d2 to d69ef7e Compare May 8, 2026 17:36
github-actions Bot added a commit that referenced this pull request May 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Benchmark Results

Hyperfine

Command Mean [ms] Min [ms] Max [ms] Relative
large_sir::baseline 3.0 ± 0.1 2.8 3.1 1.00
large_sir::entities 6.6 ± 0.1 6.4 6.9 2.23 ± 0.05

Criterion

Regressions (slower)
Group Bench Param Change CI Lower CI Upper
sample_entity sample_entity_single_property_unindexed 1000 21.575% 19.144% 23.822%
large_dataset bench_filter_unindexed_entity 16.468% 10.466% 23.089%
sample_entity sample_entity_whole_population 1000 15.660% 14.801% 16.275%
sample_entity sample_entity_whole_population 10000 15.182% 14.948% 15.396%
sample_entity sample_entity_whole_population 100000 15.133% 14.548% 15.737%
large_dataset bench_match_entity 9.821% 8.925% 11.185%
indexing query_people_count_indexed_multi-property_entities 7.391% 6.510% 8.202%
large_dataset bench_query_population_multi_indexed_entities 6.648% 6.331% 7.072%
sample_entity sample_entity_multi_property_indexed 1000 4.131% 3.698% 4.597%
sampling sampling_single_unindexed_concrete_plus_derived_entities 3.408% 3.135% 3.751%
sample_entity sample_entity_multi_property_indexed 100000 3.261% 2.973% 3.678%
sample_entity sample_entity_multi_property_indexed 10000 3.119% 2.720% 3.427%
counts index_after_adding_entities 3.022% 2.052% 4.707%
sampling count_and_sampling_single_unindexed_concrete_plus_derived_entiti 2.476% 2.237% 2.629%
sampling sampling_single_unindexed_entities 1.665% 1.315% 1.913%
Improvements (faster)
Group Bench Param Change CI Lower CI Upper
indexing query_people_single_indexed_property_entities -6.752% -7.950% -5.236%
large_dataset bench_query_population_property_entities -6.285% -7.639% -4.952%
sampling sampling_single_l_reservoir_entities -4.174% -4.735% -3.736%
indexing query_people_count_single_indexed_property_entities -3.833% -4.266% -3.400%
algorithm_benches algorithm_sampling_multiple_known_length -3.253% -3.895% -2.617%
large_dataset bench_query_population_indexed_property_entities -2.821% -3.302% -2.242%
algorithm_benches algorithm_sampling_multiple_l_reservoir -2.642% -3.247% -2.185%
indexing with_query_results_single_indexed_property_entities -2.369% -2.802% -2.041%
indexing with_query_results_indexed_multi-property_entities -2.084% -2.896% -1.442%
sample_entity sample_entity_single_property_indexed 1000 -1.974% -2.791% -1.241%
sampling sampling_multiple_unindexed_entities -1.812% -1.874% -1.760%
sample_entity sample_entity_single_property_unindexed 100000 -1.643% -2.412% -1.163%
Unchanged / inconclusive (CI crosses 0%)
Group Bench Param Change CI Lower CI Upper
examples example-basic-infection 3.889% -1.560% 8.753%
sample_entity sample_entity_single_property_unindexed 10000 2.327% 0.909% 3.941%
sample_entity sample_entity_single_property_indexed 10000 -1.473% -1.861% -0.941%
sampling count_and_sampling_single_known_length_entities -1.210% -1.769% -0.734%
counts concrete_plus_derived_unindexed_entities -1.085% -2.572% 0.161%
sampling sampling_multiple_known_length_entities -1.017% -1.283% -0.757%
counts multi_property_indexed_entities -0.946% -1.121% -0.760%
indexing query_people_indexed_multi-property_entities -0.787% -1.136% -0.537%
sample_entity sample_entity_single_property_indexed 100000 -0.782% -1.011% -0.548%
large_dataset bench_query_population_multi_unindexed_entities -0.720% -1.322% -0.166%
indexing query_people_count_multiple_individually_indexed_properties_enti -0.697% -0.868% -0.543%
sampling sampling_single_known_length_entities -0.623% -1.775% 0.705%
algorithm_benches algorithm_sampling_single_l_reservoir -0.552% -0.705% -0.405%
large_dataset bench_query_population_derived_property_entities -0.546% -1.756% 0.417%
counts single_property_indexed_entities 0.520% -0.373% 1.411%
examples example-births-deaths 0.460% -0.138% 1.133%
sampling sampling_multiple_l_reservoir_entities -0.424% -1.045% 0.474%
indexing query_people_multiple_individually_indexed_properties_entities -0.399% -0.562% -0.251%
counts multi_property_unindexed_entities 0.398% -0.303% 1.258%
counts reindex_after_adding_more_entities 0.347% 0.089% 0.604%
counts single_property_unindexed_entities -0.221% -0.858% 0.401%
large_dataset bench_filter_indexed_entity -0.179% -12.826% 13.269%
indexing with_query_results_multiple_individually_indexed_properties_enti 0.151% -0.119% 0.379%
algorithm_benches algorithm_sampling_single_known_length -0.104% -0.582% 0.303%
algorithm_benches algorithm_sampling_single_rand_reservoir -0.072% -0.454% 0.258%

Copy link
Copy Markdown
Collaborator

@k88hudson-cfa k88hudson-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobertJacobsonCDC RobertJacobsonCDC merged commit 24b50b3 into main May 8, 2026
22 checks passed
@RobertJacobsonCDC RobertJacobsonCDC deleted the RobertJacobsonCDC_834_remove_progress_bar branch May 8, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove progress bar feature

3 participants