Try to fix a warning & to allow one to pass secrets without possibly leaking them#89
Open
RaphaelIT7 wants to merge 4 commits intoCFC-Servers:mainfrom
Open
Try to fix a warning & to allow one to pass secrets without possibly leaking them#89RaphaelIT7 wants to merge 4 commits intoCFC-Servers:mainfrom
RaphaelIT7 wants to merge 4 commits intoCFC-Servers:mainfrom
Conversation
Collaborator
Author
|
Reverted it since #90 would solve the HTTP issue & it really doesn't seem to need the thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on startup a secret is shown which should be fixed by this.
(Docker slim probably nuked it, this could maybe also cause #88 ?)
And additionally, I added the optional secret
secret-startup-argsthat people can use to pass startup arguments without leaking stuff, hopefully.These changes are currently untested, one is by docker slim which is only used by the release builds, making testing more difficult & for the secret I'll have to set up the workflow again before I can test it.