Import some HTTP tests#36
Conversation
|
Haven't read yet, but thank you! We can host test pages on a subdomain on gluatest.com? |
I'm worried that putting any kind of additional layer in between (reverse proxy, Cloudflare, etc.) or switching to another language (e.g. PHP) may break the sometimes very-intentionally-broken test cases. Additionally, having this as a locally runnable Python script is probably the best we can get for developer experience, we just need to figure out where to place the following in the CI setup: Also, thinking about it, probably a good idea to disable the tests (instead of letting them fail) if the HTTP server isn't running. |
bb5c636 to
a0370db
Compare
|
Figured out launching the server, killing it is optional at this point in time. Now why does EDIT: How much will explode if I just |
9bd6ec4 to
d4e6ee6
Compare
d4e6ee6 to
954b8bc
Compare
|
Could I get some workflow approval for this? |
|
The x86-64 failure we also get on main, so I suppose this is merge-ready now? Codifying the differences for dedicated servers I will submit in another PR down the line. |
|
Bump? :^) |
|
iirc like 9 months ago when @sarahsturgeon thought of HTTP tests we'd concluded to include the HttpServer module from HolyLib into HolyTest to be used for that purpose. |
I have been writing behavior tests for HTTP while testing CHTTP, figured I might as well clean them up and import the tests that apply to both.
Draft until I figure out where I can start and kill the testing HTTP server.