Provide artBase URL in config to load album art correctly#28
Open
hdurdle wants to merge 2 commits into
Open
Conversation
The underlying sonos API sometimes returns relative urls for album art, which can't be loaded in all circumstances. This allows you to provide a config option for a base URL for the art to load from. Put this in config.js: artBase: 'http://10.107.0.50:1400' where that is the IP of a Sonos device on your network. It doesn't need to be one in the group playing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying node-sonos-http-api API sometimes returns relative urls for album art, which can't be loaded in all circumstances. See jishi/node-sonos-http-api#673
This change allows you to provide a config option for a base URL for the art to load from. Put this in your MMM-Sonos config section in config.js:
where that is the IP of a Sonos device on your network. It doesn't need to be one in the group playing.
This is working for me on my install - tested with, TuneIn, Spotify, SoundCloud, Audible, Plex and the local music library.