fix: restore getCaptureStatus() — was hardcoded to return None#1210
Open
fix: restore getCaptureStatus() — was hardcoded to return None#1210
Conversation
LLVM 22 SPIR-V triggers an IGC driver bug on i915 igpus with emulated double precision (IGC_EnableDPEmulation). The testInt2Double kernel causes ZE_RESULT_ERROR_DEVICE_LOST / GPU hang on UHD 730/770. The SPIR-V for the kernel itself is identical to LLVM 21, but the module-level SPIR-V differences (rounding-mode conversion kernels) cause IGC to produce bad machine code for the igpu. Test passes on dgpu (Arc A380/A770) and on igpu with LLVM 21. Excluded via --regex-exclude on igpu only, until IGC is fixed.
pvelesko
force-pushed
the
fix-hipgraph-stub
branch
from
3ba5085 to
ba0f14d
Compare
getCaptureStatus() had its real implementation commented out with a TODO, always returning hipStreamCaptureStatusNone. This caused hipStreamEndCapture to always fail with hipErrorIllegalState (401). Unblocks 384 rocSPARSE graph_test failures and rocRAND hipgraph test.
pvelesko
force-pushed
the
fix-hipgraph-stub
branch
from
ba0f14d to
3faecac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCaptureStatus()inCHIPBackend.hhhad its real implementation commented out with a TODO, hardcoded to always returnhipStreamCaptureStatusNone. This causedhipStreamEndCaptureto always fail withhipErrorIllegalState(401).Impact
graph_testfailures (all stream-capture-based tests)test_rocrand_hipgraphshipStreamBeginCapture/hipStreamEndCaptureTest plan