refactor: de-normalize per-query method classification to a varchar column

[TheWitness]

Summary

Follow-up to #47 (the import memory fix). Addresses the over-normalization you flagged: plugin_slowlog_details_methods stored a methodid foreign key into the plugin_slowlog_methods dictionary, so every read path (stats cache build, By Method chart, details list, method filter dropdown, chart-scope list) had to JOIN the dictionary, and import had to look method ids up.

Changes

• Schema: plugin_slowlog_details_methods.methodid (int FK) → method varchar(45), stored directly. Primary key is now (logid, logentry, method).
• Classification: the method→fragment dictionary moved from the plugin_slowlog_methods table into a PHP constant, SLOWLOG_METHOD_FRAGMENTS; import_post_process() and the OTHER TABLES / OTHERS bucketing write the method name directly.
• Reads de-joined: slowlog_collect_stats_by_method(), slowlog_get_chart_object_live() (By Method), the details-list query in slowlog.php, the method filter dropdown, and slowlog_get_chart_scope_items() all now read plugin_slowlog_details_methods.method directly — no plugin_slowlog_methods join.
• Dictionary tables left in place but unused: plugin_slowlog_methods and plugin_slowlog_tables are still created (so upgrades don't error); per your note, a clean install drops them.
• Stats cache kept (plugin_slowlog_stats) — unchanged; it's already memory-safe (bounded reservoir + exact count/sum).

Tests

• ImportPostProcessMethodsTest / OtherTablesClassificationTest updated to assert method names instead of ids, and the removed methodid-lookup guard's test was dropped.
• ComputeStatsTest, SetupTableApiUsageTest, TableModeDispatchTest, PreparedStatementUsageTest pass unchanged.

php -l clean on all changed files. No version bump; CHANGELOG updated under 2.6.

Note: this branches off main (independent of #47); they touch different functions and merge cleanly.

[Copilot]

Copilot review overview

🟡 Changes recommended

Existing installations lack the migration needed by the new method-column inserts and queries.

Review effort: Balanced
Findings: 1

Open (1)

• Add migration for existing tables and unchanged installed versions · New

What changed in this PR

Simplifies slowlog method classification by storing method names directly, complementing #47’s separate import-memory fix.

Changes:

• Replaces method IDs with names and moves classifier fragments into PHP constants.
• Removes method-dictionary joins from statistics, charts, and detail queries.
• Updates classification tests and the changelog.

File	Description
tests/​Unit/​OtherTablesClassificationTest.php	Asserts named classification buckets.
tests/​Integration/​ImportPostProcessMethodsTest.php	Verifies method-name inserts and classifications.
slowlog.php	Filters and displays methods by name.
includes/​slowlog_functions.php	Uses method constants and simplifies read queries.
includes/​database.php	Changes the association table’s create-time schema.
CHANGELOG.md	Documents the de-normalization.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.