Repository navigation
fix(database): [1.2.x] preserve poll state and bound interrupted retries - #663
Open
somethingwithproof wants to merge 5 commits into
Open
somethingwithproof wants to merge 5 commits into
somethingwithproof wants to merge 5 commits into
Conversation
…tion Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
…tries-1.2-fix Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Also zero the details array and keep polling a device whose RECACHE query fails. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport the applicable database/polling bugs from develop #641, #660 and #655. Use pool-owned MYSQL handles through reconnect, choose upsert syntax from the actual write destination, and count interrupted reconnect attempts. SQL error paths keep using credential-redacted logging.
Retain one shared completion record per device instead of resetting it when each partition launches. Failed output/reindex/bookkeeping writes prevent schedule advancement, and the last completed partition advances it only after all earlier writes succeed. Database calls run outside the completion lock. Check poll error-buffer allocations before dereference.
Merge after #662. Keeps maintenance fail-fast query behavior and flat source layout. Release notes will be collected in the final maintenance PR.
Validation: native build and version smoke test pass through mise. ASan/UBSan contracts cover partition completion/failures, actual destination syntax for MariaDB and MySQL versions, and bounded EINTR/deadlock retries. The critical flawfinder gate passes. No live database or device was contacted.