Replace export_rewrites with simp where possible #1264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnezam
added
the
test failing
dnezam
force-pushed
the
export_rewrites-simp
branch
from
5d280ed to
2f182ca
Compare
There are a few things worth pointing out: 1. I've slightly restructured some new_specification calls. In particular, I factored out the proof into a local theorem, and more importantly, I factored out the string name into a variable (see clFFIScript.sml). The motivation for the latter was to ultimately ban `export_rewrites["`, but it turns out that there are still good uses for this (for example when adding definitions/theorems from other theories to the simpset). Arguably, it gets rid of some duplication, which is why I haven't reverted it. 2. I've adjusted various tutorial files to use simp tags, since presumably we want newcomers to be exposed to that. simple_bstScript.sml still mentions what it desugars to at some point, so it should be fine. 3. I deleted astPropsScript.sml -- there was a TODO that said to do it, and it also had commented out export_rewrites.
dnezam
force-pushed
the
export_rewrites-simp
branch
from
79cc52d to
704e36e
Compare
dnezam
removed
the
test failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few things worth pointing out:
I've slightly restructured some new_specification calls. In particular, I factored out the proof into a local theorem, and more importantly, I factored out the string name into a variable (see clFFIScript.sml). The motivation for the latter was to ultimately ban
export_rewrites[", but it turns out that there are still good uses for this (for example when adding definitions/theorems from other theories to the simpset). Arguably, it gets rid of some duplication, which is why I haven't reverted it.I've adjusted various tutorial files to use simp tags, since presumably we want newcomers to be exposed to that. simple_bstScript.sml still mentions what it desugars to at some point, so it should be fine.
I deleted astPropsScript.sml -- there was a TODO that said to do it, and it also had commented out export_rewrites.