-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix double quote characters #1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughReplace typographic (curly) quotes with standard ASCII double quotes across multiple changelog files in both YAML front-matter Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/web/content/changelog/73.mdx (1)
18-18: Out-of-scope style suggestion flagged by static analysis.LanguageTool flagged "needs input" as nonstandard double modal usage. However, this appears unrelated to the quote-fix PR objective and may be a pre-existing content issue. Consider addressing it separately if desired, but it's not blocking this change.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
apps/web/content/changelog/73.mdx(1 hunks)apps/web/content/changelog/74.mdx(1 hunks)apps/web/content/changelog/76.mdx(1 hunks)apps/web/content/changelog/77.mdx(1 hunks)apps/web/content/changelog/78.mdx(1 hunks)apps/web/content/changelog/79.mdx(1 hunks)apps/web/content/changelog/8.mdx(1 hunks)apps/web/content/changelog/80.mdx(1 hunks)apps/web/content/changelog/81.mdx(1 hunks)apps/web/content/changelog/82.mdx(1 hunks)
🧰 Additional context used
🪛 LanguageTool
apps/web/content/changelog/73.mdx
[style] ~18-~18: The double modal “needs input” is nonstandard (only accepted in certain dialects). Consider “to be input”.
Context: ...diagnose rare crashes. * Clearer "needs input" error handling in the desktop flow. * ...
(NEEDS_FIXED)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Typecheck
🔇 Additional comments (9)
apps/web/content/changelog/73.mdx (1)
5-5: Typographic quote fix looks good.The
publishedAtfield has been correctly converted from typographic quotes to standard ASCII quotes.apps/web/content/changelog/79.mdx (1)
4-4: Typographic quote fix looks good.The
publishedAtfield has been correctly converted from typographic quotes to standard ASCII quotes.apps/web/content/changelog/78.mdx (1)
4-4: Typographic quote fix looks good.The
publishedAtfield has been correctly converted from typographic quotes to standard ASCII quotes.apps/web/content/changelog/76.mdx (1)
4-4: Typographic quote fix looks good.The
publishedAtfield has been correctly converted from typographic quotes to standard ASCII quotes.apps/web/content/changelog/82.mdx (1)
4-4: Typographic quote fix looks good.The
publishedAtfield has been correctly converted from typographic quotes to standard ASCII quotes.apps/web/content/changelog/77.mdx (1)
4-4: Typographic quote fix looks good.The
publishedAtfield has been correctly converted from typographic quotes to standard ASCII quotes.apps/web/content/changelog/80.mdx (1)
4-4: Typographic quote fix looks good.The
publishedAtfield has been correctly converted from typographic quotes to standard ASCII quotes.apps/web/content/changelog/74.mdx (1)
11-11: Quote replacement was not completed.The verification found that curly quotes (U+201C/U+201D) are still present in the file, including on line 11. The grep command detected matches on multiple lines and reported "WARNING: Curly quotes found". This contradicts the review comment's claim that the quotes have been successfully replaced with ASCII quotes around "device busy".
The change described in the review comment has not been applied, or the file state does not reflect the PR changes. Please verify that the intended quote replacements were actually committed to this file.
Likely an incorrect or invalid review comment.
apps/web/content/changelog/8.mdx (1)
11-12: Lines 11–12 verified with straight ASCII quotes; however, other lines in the same file still contain curly quotes.Verification confirms lines 11–12 correctly use straight ASCII quotes ("Automatically open editor after recording" and "Sign out"). However, the file still contains curly quotes on lines 2, 3, 4, 5, 9, 10, 13, 15–17, 19–23. If the PR objective is to normalize quotes across all changelog entries in this file, additional lines require replacement.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.