Closing the UI tab in multiplayer after losing fixed#10505
Open
Madwand99 wants to merge 1 commit intoCard-Forge:masterfrom
Open
Closing the UI tab in multiplayer after losing fixed#10505Madwand99 wants to merge 1 commit intoCard-Forge:masterfrom
Madwand99 wants to merge 1 commit intoCard-Forge:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue in multiplayer matches where, after the human player had already lost, closing the match tab would only remove the UI while the remaining AI players kept playing in the background. This happened because the close/concede flow saw that no local human still needed to concede and treated the match as safe to close, even though the game itself was still running.
The fix updates AbstractGuiGame.concede() so that, in local non-network games, if all remaining active players are AI and no local human is still alive, Forge now explicitly ends the game with GameEndReason.AllHumansLost on the game thread. That allows the normal game-end cleanup path to run and prevents off-screen AI-vs-AI play from continuing after the tab is closed.