Fix network log cleanup#10557
Open
MostCromulent wants to merge 1 commit intoCard-Forge:masterfrom
Open
Conversation
cleanupOldLogs() was only invoked from setInstanceSuffix(), which is called exclusively by the parallel test executors. Normal network games go through activateNetworkLogging(), so flat network-debug-*.log files accumulated past the NET_MAX_LOG_FILES limit without ever being pruned. Run cleanup once when normal-mode logging is first activated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Network log writer is intended to retain a history of the last 10 logs and delete any older entries to avoid file bloat.
However cleanupOldLogs() was only called by the test executor, not in normal network play. This allowed network logs to accumulate past the NET_MAX_LOG_FILES limit.
Fix by adding cleanupOldLogs() to the normal network play path.