Optional Smart Token Art Selection#9756
Closed
clairchiara wants to merge 7 commits intoCard-Forge:masterfrom
Closed
Optional Smart Token Art Selection#9756clairchiara wants to merge 7 commits intoCard-Forge:masterfrom
clairchiara wants to merge 7 commits intoCard-Forge:masterfrom
Conversation
clairchiara
force-pushed
the
feature/better-token-art
branch
2 times, most recently
from
6a5500b to
33b26e7
Compare
clairchiara
force-pushed
the
feature/better-token-art
branch
from
33b26e7 to
56b2f75
Compare
Hanmac
reviewed
Feb 23, 2026
| boolean pastRealEdition = false; | ||
| final EnumSet<CardEdition.Type> coreExpansionOrReprint = EnumSet.of(CardEdition.Type.CORE, CardEdition.Type.EXPANSION); | ||
| coreExpansionOrReprint.addAll(CardEdition.Type.REPRINT_SET_TYPES); | ||
| for (CardEdition edition : this.editions.getOrderedEditions(false)) { |
Contributor
There was a problem hiding this comment.
No need for extra function.
editions is already an CardEdition.Collection extending Iterable<CardEdition>
Contributor
Author
There was a problem hiding this comment.
The goal is to find the closest edition to realEdition rather than stop at the first result (which would be the earliest release)
Contributor
There was a problem hiding this comment.
@clairchiara no i mean this:
edition : this.editions.getOrderedEditions(false) returns Sorted Collection, but not reversed
Wouldn't edition : this.editions return the same? No need for extra getOrderedEditions with different parameter?
it is already an Iterable
Contributor
Author
There was a problem hiding this comment.
this.editions isn't sorted as far as I can tell
clairchiara
force-pushed
the
feature/better-token-art
branch
3 times, most recently
from
79d02e3 to
b04d6b8
Compare
Contributor
Author
|
Messed up the rebase… |
clairchiara
force-pushed
the
feature/better-token-art
branch
3 times, most recently
from
54ecbc4 to
e7dc8da
Compare
clairchiara
force-pushed
the
feature/better-token-art
branch
from
e7dc8da to
72b4444
Compare
clairchiara
force-pushed
the
feature/better-token-art
branch
2 times, most recently
from
169efd2 to
bc2ac54
Compare
clairchiara
force-pushed
the
feature/better-token-art
branch
4 times, most recently
from
04a8c3e to
0f0f536
Compare
clairchiara
force-pushed
the
feature/better-token-art
branch
from
0f0f536 to
0e42353
Compare
RafaelHGOliveira
added a commit
to RafaelHGOliveira/forge
that referenced
this pull request
Apr 10, 2026
…(smart token art), Card-Forge#9383 (castability highlighting), Card-Forge#9890 (HiDPI deck icons)
clairchiara
force-pushed
the
feature/better-token-art
branch
3 times, most recently
from
93dde2f to
cbf46b8
Compare
clairchiara
force-pushed
the
feature/better-token-art
branch
from
cbf46b8 to
1fcbdbd
Compare
If selected, when a token isn't found for a given set, it picks the latest art released before the set or, if still not found, the earliest art released after the set
clairchiara
force-pushed
the
feature/better-token-art
branch
from
1fcbdbd to
78df607
Compare
Contributor
Author
|
It doesn’t seem that this is required anymore (#10518) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When token art for a specific set is missing, Forge currently selects a random token art. This PR introduces an optional deterministic fallback strategy based on set release order.
When art isn’t found for a given set, it goes through every set in release order and tries to find the latest art released before the set or, if still not found, the earliest art released after the set.