Skip to content

[ENG-9955] Fix meta tag "citation_author_institution" #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianjgeiger merged 1 commit into from
Dec 17, 2025
Merged

[ENG-9955] Fix meta tag "citation_author_institution" #832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions src/app/features/project/project.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,7 @@ import { ContributorsSelectors, GetBibliographicContributors } from '@osf/shared
import { AnalyticsService } from '@shared/services/analytics.service';
import { CurrentResourceSelectors } from '@shared/stores/current-resource';

import {
GetProjectById,
GetProjectIdentifiers,
GetProjectInstitutions,
GetProjectLicense,
ProjectOverviewSelectors,
} from './overview/store';
import { GetProjectById, GetProjectIdentifiers, GetProjectLicense, ProjectOverviewSelectors } from './overview/store';

@Component({
selector: 'osf-project',
Expand Down Expand Up @@ -66,8 +60,6 @@ export class ProjectComponent implements OnDestroy {
readonly isBibliographicContributorsLoading = select(ContributorsSelectors.isBibliographicContributorsLoading);
readonly license = select(ProjectOverviewSelectors.getLicense);
readonly isLicenseLoading = select(ProjectOverviewSelectors.isLicenseLoading);
readonly institutions = select(ProjectOverviewSelectors.getInstitutions);
readonly isInstitutionsLoading = select(ProjectOverviewSelectors.isInstitutionsLoading);

private readonly lastMetaTagsProjectId = signal<string | null>(null);
private readonly projectId = toSignal(this.route.params.pipe(map((params) => params['id'])));
Expand All @@ -77,14 +69,12 @@ export class ProjectComponent implements OnDestroy {
!this.isProjectLoading() &&
!this.isBibliographicContributorsLoading() &&
!this.isLicenseLoading() &&
!this.isInstitutionsLoading() &&
!!this.currentProject()
);

private readonly actions = createDispatchMap({
getProject: GetProjectById,
getLicense: GetProjectLicense,
getInstitutions: GetProjectInstitutions,
getIdentifiers: GetProjectIdentifiers,
getBibliographicContributors: GetBibliographicContributors,
});
Expand All @@ -100,7 +90,6 @@ export class ProjectComponent implements OnDestroy {
this.actions.getProject(id);
this.actions.getIdentifiers(id);
this.actions.getBibliographicContributors(id, ResourceType.Project);
this.actions.getInstitutions(id);
}
});

Expand Down Expand Up @@ -160,7 +149,6 @@ export class ProjectComponent implements OnDestroy {
publishedDate: this.datePipe.transform(project.dateCreated, 'yyyy-MM-dd'),
modifiedDate: this.datePipe.transform(project.dateModified, 'yyyy-MM-dd'),
keywords,
institution: this.institutions().map((institution) => institution.name),
contributors: this.bibliographicContributors().map((contributor) => ({
fullName: contributor.fullName,
givenName: contributor.givenName,
Expand Down
1 change: 0 additions & 1 deletion src/app/shared/services/meta-tags.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ export class MetaTagsService {
citation_title: metaTagsData.title,
citation_doi: metaTagsData.doi,
citation_publisher: metaTagsData.siteName,
citation_author_institution: metaTagsData.institution,
citation_author: metaTagsData.contributors,
citation_description: metaTagsData.description,
citation_public_url: metaTagsData.url,
Expand Down