New commit for fixing formating of nist harvester tags#507
Open
jgw4sq wants to merge 1 commit intoCenterForOpenScience:developfrom
Open
New commit for fixing formating of nist harvester tags#507jgw4sq wants to merge 1 commit intoCenterForOpenScience:developfrom
jgw4sq wants to merge 1 commit intoCenterForOpenScience:developfrom
Conversation
| for tag in tags: | ||
| if "::" in tag: | ||
| tags.remove(tag) | ||
| if tag == "": |
|
Otherwise looks good. Just that it might be more efficient to not add "::" and "" to tags in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the new commit for the nist harvester fix, with only the proper files in the commit.