Repository navigation
Add variance annotations - #28
Merged
Merged
Conversation
The `@UnsafeVariance` annotations are safe because these are all immutable data structures; we can only produce a new `TreapMap`/`TreapList` of the new type.
jtoman
approved these changes
Feb 27, 2026
jtoman
left a comment
jtoman
left a comment
There was a problem hiding this comment.
worth leaving a comment about why the variance annotations are fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds variance annotations consistent with the annotations on the base
PersistentMapandPersistentListinterfaces.The
@UnsafeVarianceannotations are safe because these are all immutable data structures; we can only produce a newTreapMap/TreapListof the new type.