Skip to content

Fix resolve_to_key in message pool to be reorg stable #6910

Open
sudo-shashank wants to merge 9 commits intomainfrom
shashank/fix-resolve-to-key-mpool
Open

Fix resolve_to_key in message pool to be reorg stable #6910
sudo-shashank wants to merge 9 commits intomainfrom
shashank/fix-resolve-to-key-mpool

Conversation

@sudo-shashank
Copy link
Copy Markdown
Contributor

@sudo-shashank sudo-shashank commented Apr 15, 2026

Summary of changes

Changes introduced in this pull request:

  • Resolve to deterministic address at finality, to ensure the resolved address is reorg-stable.

Reference issue to close (if applicable)

Closes #6891

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Bug Fixes

    • Improved address resolution logic to properly respect finality lookback windows when determining key addresses for message pool operations.
    • Enhanced protocol-specific address handling to correctly reject actor address types that cannot be resolved.
  • Tests

    • Expanded test coverage for address resolution behavior with finality lookback windows.

@sudo-shashank sudo-shashank added the RPC requires calibnet RPC checks to run on CI label Apr 15, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 15, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7def56bb-bc97-44e0-8653-26db54f97557

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch shashank/fix-resolve-to-key-mpool
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch shashank/fix-resolve-to-key-mpool

Comment @coderabbitai help to get the list of available commands and usage tips.

@sudo-shashank sudo-shashank marked this pull request as ready for review April 16, 2026 07:52
@sudo-shashank sudo-shashank requested a review from a team as a code owner April 16, 2026 07:52
@sudo-shashank sudo-shashank requested review from LesnyRumcajs and hanabi1224 and removed request for a team April 16, 2026 07:52
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 90.27778% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.84%. Comparing base (0790343) to head (a29ab1d).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/message_pool/msgpool/provider.rs 63.15% 5 Missing and 2 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/message_pool/msgpool/msg_pool.rs 89.25% <100.00%> (+0.60%) ⬆️
src/message_pool/msgpool/provider.rs 54.83% <63.15%> (+0.67%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0790343...a29ab1d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

resolve_to_key in message pool should resolve at finality for reorg-safety

1 participant