Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let m6 = create_smsg(&target, &sender, wallet.borrow_mut(), 6, 1000000, 1); | ||
| let pending = vec![m5.clone(), m6]; | ||
|
|
||
| let found = find_pending_message(sender, 5, &pending).unwrap(); |
| let m5 = create_smsg(&target, &sender, wallet.borrow_mut(), 5, 1000000, 1); | ||
| let pending = vec![m5]; | ||
|
|
||
| let e = find_pending_message(sender, 99, &pending).unwrap_err(); |
| let m = create_smsg(&target, &sender, wallet.borrow_mut(), 5, 1000000, 1); | ||
| let pending = vec![m]; | ||
|
|
||
| let e = find_pending_message(other, 5, &pending).unwrap_err(); |
| let mut wallet = Wallet::new(keystore); | ||
| let addr = wallet.generate_addr(SignatureType::Secp256k1).unwrap(); | ||
|
|
||
| let e = find_pending_message(addr, 0, &[]).unwrap_err(); |
| let original_premium = TokenAmount::from_atto(100u64); | ||
| let rbf_floor = compute_rbf_minimum_premium(&original_premium); | ||
|
|
||
| let estimated = make_test_message(addr, target, 5, 2000000, 200, 500); |
| let original_premium = TokenAmount::from_atto(1000u64); | ||
| let rbf_floor = compute_rbf_minimum_premium(&original_premium); | ||
|
|
||
| let estimated = make_test_message(addr, target, 5, 2000000, 50, 500); |
| let addr = wallet.generate_addr(SignatureType::Secp256k1).unwrap(); | ||
| let target = wallet.generate_addr(SignatureType::Secp256k1).unwrap(); | ||
|
|
||
| let original = make_test_message(addr, target, 5, 1000000, 100, 300); |
| let addr = wallet.generate_addr(SignatureType::Secp256k1).unwrap(); | ||
| let target = wallet.generate_addr(SignatureType::Secp256k1).unwrap(); | ||
|
|
||
| let original = make_test_message(addr, target, 5, 1000000, 100, 300); |
| let addr = wallet.generate_addr(SignatureType::Secp256k1).unwrap(); | ||
| let target = wallet.generate_addr(SignatureType::Secp256k1).unwrap(); | ||
|
|
||
| let original = make_test_message(addr, target, 5, 1000000, 100, 300); |
| let addr = wallet.generate_addr(SignatureType::Secp256k1).unwrap(); | ||
| let target = wallet.generate_addr(SignatureType::Secp256k1).unwrap(); | ||
|
|
||
| let original = make_test_message(addr, target, 5, 1000000, 100, 300); |
sudo-shashank
force-pushed
the
shashank/nonce-fix-cmd
branch
from
078a644 to
6c3da7c
Compare
sudo-shashank
force-pushed
the
shashank/nonce-fix-cmd
branch
from
6c3da7c to
1f52ab9
Compare
sudo-shashank
force-pushed
the
shashank/nonce-fix-cmd
branch
from
1f52ab9 to
f7f12ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
nonce-fixandreplacecli commands.Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions