Skip to content

Comments

[Chore] Release version 1.3.16#705

Merged
dingyi222666 merged 1 commit intov1-devfrom
fix/core-bug
Jan 30, 2026
Merged

[Chore] Release version 1.3.16#705
dingyi222666 merged 1 commit intov1-devfrom
fix/core-bug

Conversation

@dingyi222666
Copy link
Member

Summary

This PR bumps the version to 1.3.16 with minor fixes and improvements.

Bug fixes

  • Fix logger to only output debug message when log files were actually deleted

Other Changes

  • Add currentConfig property declaration to ChatLunaService for improved type safety
  • Update peer dependencies across all packages to 1.3.16

- Update core package version from 1.3.15 to 1.3.16
- Update peer dependencies across all packages to 1.3.16
- Add currentConfig property declaration to ChatLunaService for improved type safety
- Fix logger to only output debug message when log files were actually deleted
@dingyi222666 dingyi222666 merged commit 9a686d6 into v1-dev Jan 30, 2026
1 of 3 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 30, 2026

Caution

Review failed

The pull request is closed.

概览

本次变更在 ChatLunaService 中新增了公开属性 currentConfig,同时优化了日志记录工具中删除旧日志文件的调试消息,使其仅在实际删除文件时才输出日志。

变更

变更类别 / 文件 说明
ChatLunaService 配置属性
packages/core/src/services/chat.ts
向 ChatLunaService 添加公开属性 currentConfig,在构造函数中初始化为传入的 config 对象,提供配置的可访问引用。
日志输出条件化
packages/core/src/utils/logger.ts
修改 trackLogToLocal 函数中删除旧日志文件的调试日志,使其仅在至少删除一个文件时才输出相关消息,避免无文件删除时的虚假日志。

预计代码审查工作量

🎯 2 (Simple) | ⏱️ ~8 分钟

可能相关的 PR

  • PR #702: 系统性地将 ChatLunaService 及其消费者从使用 config 切换为使用 currentConfig,与本 PR 新增的 currentConfig 属性密切相关。
  • PR #700: 同样修改 packages/core/src/utils/logger.ts 中日志清理逻辑,调整"删除旧日志文件"消息的触发时机和追踪方式。

诗歌

🐰 配置配置悄悄装,currentConfig 在心上,
日志聪慧有了脑,文件删除才开口。
小小优化大智慧,代码清爽润心间。

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/core-bug

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dingyi222666, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on a routine version update to 1.3.16 for the koishi-plugin-chatluna ecosystem. It includes a minor bug fix to refine logging behavior, ensuring debug messages for log file deletion are only shown when relevant. Additionally, it enhances type safety within the ChatLunaService by explicitly declaring a configuration property.

Highlights

  • Version Bump: The core package koishi-plugin-chatluna has been updated to version 1.3.16.
  • Dependency Updates: All related adapter, extension, renderer, and service packages have had their koishi-plugin-chatluna peer dependency updated from ^1.3.14 to ^1.3.16.
  • Logger Improvement: The logger now only outputs debug messages when log files are actually deleted, reducing unnecessary log noise.
  • Type Safety Enhancement: The ChatLunaService class now explicitly declares a currentConfig property, improving type safety and clarity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily handles the version bump to 1.3.16, updating the core package and all peer dependencies in adapter and extension packages. The changes also include a fix in the logger to prevent logging when no files are deleted, and an addition of a currentConfig property in ChatLunaService.

My review focuses on the code changes. The logger fix is a good improvement. I've added a comment regarding the new currentConfig property in ChatLunaService, which appears to be redundant with the existing config property. Please take a look.


public config: Config

declare public currentConfig: Config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Service class in Koishi already provides a reactive config property which holds the current configuration. The addition of currentConfig seems redundant, as it's assigned the same config object as this.config in the constructor (line 82). Using declare here is also unconventional since the property is initialized.

To simplify the code, consider removing currentConfig (here and on line 82) and using this.config consistently. If there's a specific reason for this duplication that I'm missing, I'd be interested to learn about it.

@dingyi222666 dingyi222666 deleted the fix/core-bug branch February 3, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant