Add nd_multi_cluster_connectivity_aci resource - #38
Conversation
fa77514 to
eeb91a8
Compare
eeb91a8 to
4435d83
Compare
| TelemetryCollectionType string `json:"telemetryCollectionType,omitempty"` | ||
| TelemetryStreamingProtocol string `json:"telemetryStreamingProtocol,omitempty"` | ||
| Location *NDFCSpecLocationValue `json:"location,omitempty"` | ||
| Management *NDFCAciManageManagementValue `json:"management,omitempty"` |
There was a problem hiding this comment.
Many params in this are already part of fabric_common.
Are there any challenges is using the common fabric pattern for this resource?
| return | ||
| } | ||
|
|
||
| res, err := clusterAPI.Post(clusterPayload, &ndapi.APIOptions{DisablePayloadLog: true}) |
There was a problem hiding this comment.
how do we ensure the fabric is in the correct state?
There was a problem hiding this comment.
should we expose connection status?
| } | ||
|
|
||
| // RscCreateMultiClusterConnectivityAci creates a multi cluster connectivity aci resource. | ||
| func (r *multiClusterConnectivityAciResource) rscCreateMultiClusterConnectivityAci(ctx context.Context, dg *diag.Diagnostics, input *MultiClusterConnectivityAciModel) { |
There was a problem hiding this comment.
how do we handle re-registration flow? is this only ttriggered on certain attribute changes, what happens when it needs to be triggered without a change because connection went to down state?
| // TODO: The values for `username`, `password`, and `login_domain` attributes | ||
| // will not be imported when the resource imports an already registered APIC cluster. |
There was a problem hiding this comment.
do we document this behaviour? should we re-apply when we want the credentials included into state?
| return false | ||
| } | ||
|
|
||
| if clusterAPI.ClusterName == "" { |
There was a problem hiding this comment.
why would this ever be empty and not match the fabricName?
3 participants
No description provided.