Skip to content

Fixup boilerplate#116

Open
Protonull wants to merge 3 commits intoCivPlatform:mainfrom
Protonull:boilerplate-fixup
Open

Fixup boilerplate#116
Protonull wants to merge 3 commits intoCivPlatform:mainfrom
Protonull:boilerplate-fixup

Conversation

@Protonull
Copy link
Contributor

@Protonull Protonull commented Mar 16, 2026

This fixes a few of the issues mentioned in #114:

  • Now ensures that the server targets nodejs v18.
  • Switched from yarn/pnpm to npm.
  • Added .editorconfig to help prevent mixed indentation (plus fixed existing mixed indentation).
  • Removed IDE-specific config files.
  • Updated legacy project names.
  • Ran prettier.

Further changes:

  • Removed the render subproject.
  • Fixed incorrect keybind-category translation key.
  • Pruned mixin jsons of unused fields.
  • Replaced blossom with resource processing for the version filter.

@Huskydog9988
Copy link
Contributor

What's the advantages of using npm?

This ensures that the server is targeting v18. Switched from yarn/pnpm to npm. It adds an editorconfig to [help] ensure that files do not get mixed indentation (and fixed mixed indentations). Removes IDE specific config files. Updated legacy project names. Ran prettier.
@Protonull
Copy link
Contributor Author

Protonull commented Mar 17, 2026

What's the advantages of using npm?

Firstly, because it's the one package manager that everyone with nodejs is guaranteed to have. Secondly, while other package managers can be installed separately, the only way to guarantee them for MapSync, would be to define it as a dev dependency, but then devs would need to use npm at least once anyway (which then necessitates a package-lock.json), so why not just keep using it? And thirdly, as #114 and #115 have shown is that using a particular package manager (yarn) doesn't stop other package managers (pnpm) from being used and merged.

@Huskydog9988
Copy link
Contributor

Fair enough

@Protonull
Copy link
Contributor Author

Unless there is anything further, this is ready to be merged

Fixes the category translation issue. Removes some unnecessary fields from mixin jsons. Restores parchment name property. And replaces blossom with resource processing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants