Open
Conversation
Gjum
reviewed
Mar 16, 2026
...rc/main/java/gjum/minecraft/mapsync/common/net/packet/ClientboundRegionTimestampsPacket.java
Outdated
Show resolved
Hide resolved
Gjum
reviewed
Mar 16, 2026
Contributor
|
What's the advantages of using npm? |
This ensures that the server is targeting v18. Switched from yarn/pnpm to npm. It adds an editorconfig to [help] ensure that files do not get mixed indentation (and fixed mixed indentations). Removes IDE specific config files. Updated legacy project names. Ran prettier.
c6e8a0f to
57bb99c
Compare
Contributor
Author
Firstly, because it's the one package manager that everyone with nodejs is guaranteed to have. Secondly, while other package managers can be installed separately, the only way to guarantee them for MapSync, would be to define it as a dev dependency, but then devs would need to use npm at least once anyway (which then necessitates a |
Contributor
|
Fair enough |
Contributor
Author
|
Unless there is anything further, this is ready to be merged |
Fixes the category translation issue. Removes some unnecessary fields from mixin jsons. Restores parchment name property. And replaces blossom with resource processing.
fcc4d22 to
b923825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few of the issues mentioned in #114:
.editorconfigto help prevent mixed indentation (plus fixed existing mixed indentation).Further changes:
rendersubproject.