New mod list from Catalogue by RuiXuqi · Pull Request #422 · CleanroomMC/Cleanroom

RuiXuqi · 2025-08-27T12:29:44Z

This PR replaces the old Forge mod list menu with a new design from MrCrayfish's Catalogue mod, which follows MIT llicense.

The menu supports:

Customized background (must be a 512x256 PNG file)
Customized icon (a square PNG file, an item, or a block with metadata)
Customized banner (the old logoFile key in mcmod.info; it will be automatically set as the icon if it is square)

Mod developers only need to add new keys in JSON format in the mcmod.info file. The new keys are as follows:

iconFile: a string, should point to a square PNG file.
iconItem: a string, should be in the format "minecraft:stone". Metadata is allowed. This will not be applied if iconFile is valid.
backgroundFile: a string, should point to a 512x256 PNG file. It will be the mod's background.
license: a string, will be displayed at the bottom of the mod info page.
issueTrackerUrl: a string, should be a link. The "Submit Bug" button will open it when clicked.

The menu can limit the size of logos(banners) and icons, which is configured disabled by default. Also it has the ability to perfrom filters and search for a mod's dependencies and dependants. The two lists of libraries(will be hidden by default and be displayed grey in mod list) and ignored dependencies are configurable too. There is also a favourite system, allowing you to pin mods and put them in the top of the list.

The empty keys in mcmod.info will not be displayed in the info side.

Unnecessary at all. But it is cool!

MrCrayfish/Catalogue@5397ccf

So bad. But it will help back port works MrCrayfish/Catalogue@4f71627

📦 Added missing background when no texture provided 📦 Icon will now be used if no banner texture is available 🎨 Changed missing banner 📦 Improved design ✨ Last search is now remembered when returning to menu MrCrayfish/Catalogue@6260949 MrCrayfish/Catalogue@37db432 MrCrayfish/Catalogue@c22fd3d MrCrayfish/Catalogue@6b11e0f MrCrayfish/Catalogue@3fcc8ed Also make the test mod a dummy. It is not loaded at all.

MrCrayfish/Catalogue@f7321b9

MrCrayfish/Catalogue@65b4d23

✨ Added tooltip to show numbers of mods/libraries 📦 Show "no mods" label when mod list is empty

RuiXuqi · 2025-08-27T12:37:53Z

The dummy catalogue mod should be removed since it is not a real mod. However, I haven't decided what to put in the upper-left corner yet. It is a button with link to the original Catalogue mod now.

RuiXuqi · 2025-08-27T12:44:12Z

Some features like sorting from A-Z or Z-A and favourite system are not backported yet. Just because they need to be configured through a button list, which depends on the new layout system in modern minecraft.

kappa-maintainer · 2025-08-27T13:22:45Z

I see some resources you added look like come from Mojang, are they?

RuiXuqi · 2025-08-27T13:25:35Z

I see some resources you added look like come from Mojang, are they?

Only the minecraft title does

Move all the resources and java files to a separate path Load the dummy Catalogue mod, remove links

RuiXuqi · 2025-12-20T05:56:33Z

为啥语言文件里模组设置一项删了，然后单独加了catalogue的语言文件全部放forge不好吗

语言文件是因为 Catalogue 有单独的版本，便于同步内容，不然每次还得一次次改资源路径，图片之类的也同理。（当然 PR 合并之后就不需要了）
模组设置项是顺手删的，因为它对应被移除的 GuiIngameModOptions，Forge 做一半跑路了，删了这个 Gui，并且把按钮打开项改成了 GuiModList，结果字还留着，所以我把这个 key 删了，对应的 GuiIngameMenu 里的按钮文字也改成了和主菜单一样的“模组”，并且给它加上了更新图标提示。

Desoroxxx · 2025-12-21T15:20:01Z

Not my full review, but I just wanted to quickly note this:
I don't understand why the modid is so unreadable, I know that Catalogue does this, but I think it should be formatted just like the version

Desoroxxx · 2025-12-28T13:01:54Z

Also, what happens to long credits?

RuiXuqi · 2025-12-31T10:05:45Z

Also, what happens to long credits?

Move mouse on them and there will be a tooltip.

UID-503058116 · 2026-01-12T05:49:07Z

很精致的菜单

kappa-maintainer · 2026-01-22T01:47:53Z

Any progress on this?
Also, there are new conflicts now...

Rongmario · 2026-01-22T01:53:11Z

If possible, after CleanMix's PR is pulled in, I'd like the mod list to show mixin configurations for each mod, it should be easy.

RuiXuqi · 2026-01-23T13:44:48Z

Any progress on this? Also, there are new conflicts now...

All the changes have been synced and I do not have any new ideas now.

kappa-maintainer · 2026-01-23T13:48:03Z

Should we wait for CleanMix or open another PR for mixin config feature after CleanMix merged?

RuiXuqi · 2026-01-23T14:00:33Z

Should we wait for CleanMix or open another PR for mixin config feature after CleanMix merged?

I'm fine with either way. It's up to you.

Rongmario

Few things of note:

Is NotificationModUpdateScreen needed on both GuiMainMenu and GuiIngameMenu?
Ideally the textures for the GUIs can be combined (especially icons/checkboxes).
Use the cleanroom namespace rather than catalogue
- Merge lang/textures from catalogue into cleanroom namespace
Unsure if we can distribute the Minecraft logo like that
The platform service I'm unsure if needed, but we can leave it for now.
Write credits in Cleanroom's mod meta/info:
Thanks to MrCrayFish for his Catalogue mod for the backbone of our revamped mod list screen.

Rongmario · 2026-01-23T20:08:45Z

src/main/java/com/cleanroommc/catalogue/CatalogueConfig.java

+import org.jetbrains.annotations.NotNull;
+
+@Config(modid = CatalogueConstants.MOD_ID)
+public class CatalogueConfig {


Allow this to be part of Cleanroom's configurations, we'll need a cleanroom directory in configs, and this could be modlist.cfg, name can be change in the @Config annotation.

src/main/java/com/cleanroommc/catalogue/CatalogueConfig.java

Rongmario · 2026-01-23T20:11:13Z

src/main/java/com/cleanroommc/catalogue/Utils.java

+    public static ResourceLocation resource(String name) {
+        return new ResourceLocation(CatalogueConstants.MOD_ID, name);
+    }
+
+    public static ResourceLocation withDefaultNamespace(String name) {
+        return resource("textures/gui/sprites/" + name + ".png");
+    }


Use cleanroom as namespace

src/main/java/com/cleanroommc/catalogue/Utils.java

src/main/java/com/cleanroommc/catalogue/client/CleanroomModData.java

Rongmario · 2026-01-23T21:17:33Z

src/main/java/com/cleanroommc/catalogue/client/screen/CatalogueModListScreen.java

+            ITEM_ICON_CACHE.put(this.data.getModId(), new ItemStack(Blocks.GRASS));
+
+            // Minecraft is a grass block
+            if (this.data.getModId().equals("minecraft")) return new ItemStack(Blocks.GRASS);
+
+            // Special case for Forge to set item icon to anvil
+            if (this.data.getModId().equals("forge")) {
+                ItemStack anvil = new ItemStack(Blocks.ANVIL);
+                ITEM_ICON_CACHE.put("forge", anvil);
+                return anvil;
+            }


Don't cache these, it'll be fine.

src/main/java/com/cleanroommc/catalogue/client/screen/CatalogueModListScreen.java

Rongmario · 2026-01-23T21:18:34Z

src/main/java/com/cleanroommc/catalogue/client/screen/CatalogueModListScreen.java

+                CatalogueConstants.LOG.debug("Failed to draw icon for mod '{}'", this.data.getModId(), e);
+                ITEM_ICON_CACHE.put(this.data.getModId(), new ItemStack(Blocks.GRASS));
+                this.icon = new ItemStack(Blocks.GRASS);


Fallback to new ItemStack(Blocks.COBBLESTONE)

src/main/java/com/cleanroommc/catalogue/client/screen/CatalogueModListScreen.java

Rongmario · 2026-01-23T21:20:11Z

src/main/java/com/cleanroommc/catalogue/CatalogueConstants.java

There will be no need for this to be another mod, it'll be part of Cleanroom.

There will be no need for this to be another mod, it'll be part of Cleanroom.

I didn't find a final LOGGER named Cleanroom or String "cleanroom". Where should I put them?

Desoroxxx · 2026-01-25T15:37:09Z

Quick question, does this keep the same functionality that I implemented in my previous PR's? I think it’d be a pretty bad regression to lose all the info (see my previous PR's)

#313
#319
#321

Rongmario · 2026-01-30T02:26:43Z

I agree with @Desoroxxx, though #313 and #319 will probably be superseded, but #321 should be integrated

RuiXuqi · 2026-01-30T10:17:27Z

Quick question, does this keep the same functionality that I implemented in my previous PR's? I think it’d be a pretty bad regression to lose all the info (see my previous PR's)

#313 #319 #321

#321 has been handled with new I18n support. The only thing missing is version improvment in #319.

Also update some old links and add some new keys, copied from 1.20.1 forge toml.

Desoroxxx · 2026-01-31T19:13:06Z

Probably my last question, but, isn't this a ton of abstraction and complexity for what feels like just a simple mod list. The UI isn't doing something crazy here yet it's 5k LoC

RuiXuqi · 2026-02-05T13:42:04Z

Probably my last question, but, isn't this a ton of abstraction and complexity for what feels like just a simple mod list. The UI isn't doing something crazy here yet it's 5k LoC

DropdownMenu +503: Maybe a bit too complex.
CatalogueListExtended +397: Copies tons of vanilla code to fully control the list style. Have been simplified by using pattern variables.
CatalogueTextField +155: Copies render code for string formatter, and adds a Consumer<String> responder to replace vanilla's odd interface. Also patches some respond methods missing in 1.12.2 but solved in modern mc versions.

The core CatalogueModListScreen takes 1387.

RuiXuqi added 25 commits August 19, 2025 19:56

init

6ee3fea

Lang keys

7d90fab

Sync changes

b72cf62

Adapt cleanroom version check

228df8f

Change search lang key

2f54366

More metadata

4bb77d9

"/" is a problem

fc61b53

Minecraft should be a grass block

a0504da

Logos

b56b4fa

Unnecessary at all. But it is cool!

Update forge and mcp logo, add logoBlur and iconBlur

1648a0b

Background

fe30282

MrCrayfish/Catalogue@5397ccf

Add a dummy mod. TEST ONLY.

5d64fe0

Update CatalogueContainer.java

595b361

The Great Rename

965d082

So bad. But it will help back port works MrCrayfish/Catalogue@4f71627

Update CatalogueModListScreen.java

4c5057d

Optimize

9c27fb9

Change root folder name, remove the old mod list

d9592b2

Delete GuiSlotModList.java

b8aa362

📦 Cleaned up banner and icon drawing

0ae99b9

MrCrayfish/Catalogue@f7321b9

✨ Added Ctrl + F to focus search textfield

e28f8d8

MrCrayfish/Catalogue@65b4d23

Slight tweaks

b989b98

✨ Added tooltip to show numbers of mods/libraries 📦 Show "no mods" label when mod list is empty

Update CatalogueContainer.java

31142d9

Update lang, remove mod options keys

4d74274

Fix typo

a4a9c1d

Move path, load the dummy mod

9e95deb

Move all the resources and java files to a separate path Load the dummy Catalogue mod, remove links

Fix window width and height

8eab721

kappa-maintainer requested a review from Rongmario December 21, 2025 03:22

Rehandle child mods

2c7ced2

Rongmario requested changes Jan 23, 2026

View reviewed changes

RuiXuqi added 4 commits January 30, 2026 19:10

Inner version fallback

cfbca69

Merge branch 'mod-list' into mod-list-sync

2cdfdfe

Sync main branch

dbc0b05

Fix width calculation

6e37d03

RuiXuqi force-pushed the mod-list branch from 3970df7 to 6e37d03 Compare January 30, 2026 12:13

RuiXuqi added 6 commits January 30, 2026 21:27

Handle some of the review suggestions

84f599f

Also update some old links and add some new keys, copied from 1.20.1 forge toml.

Add kirino to library list

bc8b537

Format

45cde05

Use new switch

1188f27

Fix suggestion sometimes not updated

f88b394

Optimize

dac3d26

Conversation

RuiXuqi commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RuiXuqi commented Aug 27, 2025

Uh oh!

RuiXuqi commented Aug 27, 2025

Uh oh!

kappa-maintainer commented Aug 27, 2025

Uh oh!

RuiXuqi commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RuiXuqi commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Desoroxxx commented Dec 21, 2025

Uh oh!

Desoroxxx commented Dec 28, 2025

Uh oh!

RuiXuqi commented Dec 31, 2025

Uh oh!

UID-503058116 commented Jan 12, 2026

Uh oh!

kappa-maintainer commented Jan 22, 2026

Uh oh!

Rongmario commented Jan 22, 2026

Uh oh!

RuiXuqi commented Jan 23, 2026

Uh oh!

kappa-maintainer commented Jan 23, 2026

Uh oh!

RuiXuqi commented Jan 23, 2026

Uh oh!

Rongmario left a comment

Choose a reason for hiding this comment

Uh oh!

Rongmario Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Rongmario Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Rongmario Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Rongmario Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Rongmario Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

RuiXuqi Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Desoroxxx commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rongmario commented Jan 30, 2026

Uh oh!

RuiXuqi commented Jan 30, 2026

Uh oh!

Desoroxxx commented Jan 31, 2026

Uh oh!

RuiXuqi commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

RuiXuqi commented Aug 27, 2025 •

edited

Loading

RuiXuqi commented Aug 27, 2025 •

edited

Loading

RuiXuqi commented Dec 20, 2025 •

edited

Loading

Desoroxxx commented Jan 25, 2026 •

edited

Loading