Fix: use right variable for allocating exchange matrix#47
Merged
Conversation
sayeg84
requested review from
aguljas,
jacopoventurin,
kbno and
yaoyic
as code owners
kbno
approved these changes
Apr 14, 2026
Collaborator
kbno
left a comment
kbno
left a comment
There was a problem hiding this comment.
Looks good to me, I tested on my PT sims and they run, thanks for checking this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Describe your changes here:
Main branch currently uses the wrong variable to allocate the size of the exchange matrix in PT. This causes the simulation to crash at the first saving attempt.
This fix uses the right variable to allocate the variable. Tested that the simulation runs and exits saving the right shapes.
.