Add RCEMIPII analytic sounding initial condition #4127
Conversation
trontrytel
left a comment
trontrytel
left a comment
There was a problem hiding this comment.
LGTM! Left some minor comments about how I would vote to handle the initial condition option.
From the plots I can't tell how accurately we match the paper because the axis etc are slightly different.
Also, do you have a CI case with it already? And if not, would it be useful to add one?
haakon-e
left a comment
haakon-e
left a comment
There was a problem hiding this comment.
Great work on the PR! Apart from the pressure units, I think everything looks consistent with the paper.
The code suggestions are for improved readability and documentation.
oalcabes
force-pushed
the
oa/rce_initial_sounding
branch
5 times, most recently
from
8ade5b6 to
1273629
Compare
|
And I think Wing et. al. (2018) RCEMIP is actually RCEMIPI, not RCEMIPII:) |
oalcabes
force-pushed
the
oa/rce_initial_sounding
branch
7 times, most recently
from
a401988 to
ac0dce4
Compare
| agents: | ||
| slurm_mem: 20GB | ||
|
|
||
| - label: ":computer: CRM rcemipii in a box with 1M" |
There was a problem hiding this comment.
Would it make sense to add it to reproducibility tests and get a warning every time results change? I think this is one of the better tests for microphysics we have in Atmos now
There was a problem hiding this comment.
And is it ok to remove some aquaplanet 1M / 2M tests after this is merged? If so I can do it in a separate PR.
There was a problem hiding this comment.
I think you would have to
- add
reproducibility_test: trueflag to the config file - add something like this to the pipeline (there are plenty of examples to look at there):
julia --color=yes --project=.buildkite reproducibility_tests/test_mse.jl
--job_id your_job_id
--out_dir your_job_id/output_active
- Copy the
all_best_msedict template from the job's log - Paste the
all_best_msedict template intoreproducibility_test/your_job_id.jl
There was a problem hiding this comment.
Haven't done it in a while, so please lmk if it doesn't work and I can help
docs/src/api.md
Outdated
| ClimaAtmos.InitialConditions.RCEMIPIIProfile_300 | ||
| ClimaAtmos.InitialConditions.RCEMIPIIProfile_305 |
There was a problem hiding this comment.
PS: These don't have a docstring currently
oalcabes
force-pushed
the
oa/rce_initial_sounding
branch
2 times, most recently
from
24d04ae to
622bd24
Compare
oalcabes
force-pushed
the
oa/rce_initial_sounding
branch
3 times, most recently
from
db5632b to
33778d8
Compare
oalcabes
force-pushed
the
oa/rce_initial_sounding
branch
from
33778d8 to
187e7aa
Compare
In this PR I am adding the initial sounding from the Wing et. al. (2018) RCEMIP paper. This sounding should be used for RCEMIP simulations. There are three options for initial temps of 295K, 300K, and 305K. This PR also adds an option for a cloud resolving model (CRM) setup of RCEMIP with 1M and noneq to ci.
See here the analytic profile derived from an observation from Wing et. al. (2018) (left) and the Julia implementation (right).
