Repository navigation
Conversation
imreddyTeja
reviewed
Oct 16, 2026
| # NCDatasets.jl uses CFTime.jl, which supports a time resolution of | ||
| # an attosecond, whereas Dates.DateTime only supports a time | ||
| # resolution of a millisecond. | ||
| return reinterpret.(Ref(Dates.DateTime), ds[time_dim][:]) |
Member
There was a problem hiding this comment.
why does this need to be reinterpret... this seems sketchy. Is there another way to do this?
Member
Author
There was a problem hiding this comment.
Base.reinterpret is defined for types in CFTime.jl and it is documented. See https://juliageo.org/CFTime.jl/stable/#Base.reinterpret
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the review in #258, it mentioned that the time dimension is accessed from a dataset instead of the variable of interest. This PR makes the same kind of change in #258 to get the right time dimension if there are two or more time dimensions in the dataset.
TODO