Repository navigation
Conversation
Coverage instrumentation slows the 1M bulk tendencies about 20-fold on Julia 1.12 (LinearizedAverage: 0.41 us plain, 8.9 us with coverage), so the timing budgets in test/performance_tests.jl measured the instrumentation and failed on the 1.12 jobs. The ci jobs now run without coverage, so their benchmarks time the code itself. Coverage comes from the CodeCov workflow alone, which already uploaded it on every pull request. Under coverage, bench_press skips the timing check and keeps the allocation checks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
==========================================
+ Coverage 93.17% 93.89% +0.71%
==========================================
Files 59 55 -4
Lines 3166 3078 -88
==========================================
- Hits 2950 2890 -60
+ Misses 216 188 -28
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make the timing checks in
test/performance_tests.jlmeasure the code instead of the coverage instrumentation. They fail on every Julia 1.12 job since #811, although the code runs well within its budgets.Content
The
cijobs ran the tests with coverage. On Julia 1.12, coverage slows the 1M bulk tendencies about 20-fold, so the timing budgets failed:LinearizedAverage, Float64Measured locally on main (Apple M-series); the coverage numbers on 1.12 match those in the CI logs of #811, #797 and #801.
cijobs now run without coverage, so their benchmarks time the code itself. Coverage comes from theCodeCovworkflow alone, which already runs the test suite with coverage on every pull request and uploads it.bench_pressskips the timing check when coverage is on and keeps the allocation checks. Without this, a timing failure in theCodeCovjob would fail the job and skip its coverage upload.Locally on Julia 1.12, all 536 performance checks pass without coverage. With coverage, the 134 timing checks are reported as broken and the 402 others pass.
Codecov now receives one upload per push, from Julia 1.11 on Ubuntu, instead of seven, so lines that run only on another Julia version or operating system no longer count as covered.
This supersedes #760.
Breaking changes
None.