Surface fluxes refactor to streamline it and make it more flexible #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inger parameters from file
tapios
force-pushed
the
ts/API-refactor
branch
from
7246c1c to
6855922
Compare
| q_vap_int, | ||
| q_vap_sfc, | ||
| ρ_sfc, | ||
| ) |
Member
There was a problem hiding this comment.
These methods are more transparent than the existing (param_set, sc) arg pattern ; all method updates following the new pattern are generally reasonable.
| F_m = UF.dimensionless_profile(uf_params, Δz, ζ, z0m, UF.MomentumTransport()) | ||
| F_h = UF.dimensionless_profile(uf_params, Δz, ζ, z0h, UF.HeatTransport()) | ||
|
|
||
| Ch = κ^2 / (F_m * F_h) |
Member
There was a problem hiding this comment.
With the UniversalFunctions.jl fix for near-neutral continuity the catch statements against tol_neutral are no longer necessary. Again the explicit argument list is more transparent so LGTM!
src/types.jl
Outdated
| q_star::FT | ||
| L_star::FT | ||
| theta_v_star::FT | ||
| ell_u::FT |
Member
There was a problem hiding this comment.
\scrl or ell here was inspired somewhat by ClimaOcean nomenclature, z0_u ,z0_q, z0_theta as in the profile recovery functions may be a clearer description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To-do
Content