ci: roll pinned ClickHouse versions forward to LTS + 3 latest - #960
Open
polyglotAI-bot wants to merge 2 commits into
Open
ci: roll pinned ClickHouse versions forward to LTS + 3 latest#960polyglotAI-bot wants to merge 2 commits into
polyglotAI-bot wants to merge 2 commits into
Conversation
The integration-tests-local-single-node job pinned a stale window of ClickHouse versions (26.2, 26.1, 25.12, 25.11, 25.10), all now outside the current support window. Replace them on node 24 with the current support set: 25.8 (LTS), 26.3 (LTS), 26.5, 26.6, 26.7 (3 latest). The [head, latest] base matrix continues to cover the bleeding edge. CI-only change; no client behavior change.
polyglotAI-bot
requested review from
mshustov and
peter-leonov-ch
as code owners
July 23, 2026 19:43
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Node CI workflow’s pinned ClickHouse server versions for the integration-tests-local-single-node job to match the currently supported window (current LTS lines plus the 3 latest minors), while keeping the existing head/latest baseline coverage intact.
Changes:
- Replaces the stale pinned ClickHouse minors in the matrix
include:list with25.8,26.3,26.5,26.6,26.7(Node 24, default log level). - Leaves the base matrix (
clickhouse: [head, latest]) unchanged to continue covering bleeding-edge versions.
Unquoted YAML scalars parse as floats (e.g. 26.10 -> 26.1), which would interpolate into the wrong Docker image tag (clickhouse/clickhouse-server) on a future window roll. Quoting the pinned versions keeps them as strings matching the server tags. The current set already round-trips safely; this hardens the matrix against later rolls. Addresses Copilot review feedback on #960.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Roll the stale pinned ClickHouse version window in CI forward to the current support set.
The
integration-tests-local-single-nodejob in.github/workflows/tests-node.ymlpinnednode: 24against a now-stale window of ClickHouse server versions —26.2, 26.1, 25.12, 25.11, 25.10— all outside the current support window. This replaces them with the current support set:25.8(LTS)26.3(LTS)26.5,26.6,26.7(3 latest)The base matrix (
clickhouse: [head, latest]) is unchanged and continues to cover the bleeding edge; only the explicitinclude:pins are rolled forward. js's window model (a spread of pinned minors alongsidehead/latest) is preserved.Why
ClickHouse 26.7 has been released and 26.4 reached EOL, so the pinned window (newest pin was
26.2) had drifted behind the supported releases. Pinning both current LTS lines (25.8, 26.3) plus the three newest minors keeps the version-specific regression coverage meaningful. Maintainer request, 2026-07-23.Notes
AGENTS.md, changelogs are for observable-behavior / public-API changes) and no version bump.docker manifest inspect clickhouse/clickhouse-server:<v>).Test plan
nodeworkflow'sintegration-tests-local-single-nodematrix runs green on25.8, 26.3, 26.5, 26.6, 26.7(node 24).