feat: adding correct tool annotations#184
Open
vanhtuan0409 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolAnnotationswithreadOnlyHintto all registered toolslist_databases,list_tables, andrun_chdb_select_queryare marked asreadOnlyHint=True(always read-only)run_queryannotation is set dynamically based onCLICKHOUSE_ALLOW_WRITE_ACCESS: read-only by default, non-read-only when write access is enabledMotivation
MCP clients (e.g. Claude Code, ChatGPT) use tool annotations to decide whether to prompt users for confirmation before executing a tool call. Without annotations, clients may conservatively require confirmation for every call — even read-only ones like listing databases or tables.
Test plan
list_databases,list_tables,run_chdb_select_queryexposereadOnlyHint=truein tool metadatarun_queryexposesreadOnlyHint=truewhenCLICKHOUSE_ALLOW_WRITE_ACCESSis unset orfalserun_queryexposesreadOnlyHint=falsewhenCLICKHOUSE_ALLOW_WRITE_ACCESS=true🤖 Generated with Claude Code