Docs/document proxy path and truststore env vars#196
Open
arekborucki wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Documents two existing-but-undocumented environment variables in the README:
CLICKHOUSE_PROXY_PATHread inClickHouseConfig.proxy_path(mcp_clickhouse/mcp_env.py) and passed toclickhouse_connect.get_client(proxy_path=...). For ClickHouse servers served under a sub-pathbehind an HTTP proxy.
MCP_CLICKHOUSE_TRUSTSTORE_DISABLEread inmcp_clickhouse/__init__.py; unless set to"1", the package callstruststore.inject_into_ssl()at startup. Setting it to"1"falls back to Python'sdefault SSL handling. Complements the existing
CLICKHOUSE_VERIFYtruststore note.Why
Both are user-configurable but absent from the docs, so users behind proxies or with custom TLS setups can't discover them without reading the source.
Notes
Docs-only change. purely additive, no code or tests affected.