add support for write-only password and version in #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove no-pr-activity label or comment or this will be closed in 10 days. |
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove no-pr-activity label or comment or this will be closed in 10 days. |
Contributor
|
This PR was closed because it has been stalled for 10 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow the password to be write-only, just like in the example in the ticket we’ve been working with, and similar to patterns used in other providers like google-provider.
Since password_wo (write-only) isn’t stored in state, it would get marked for update on every plan. To handle that, I introduced a password_wo_version attribute, which is tracked in state. If someone wants to rotate or update the password, they just bump the version — simple and explicit.